Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Add network interface dropdown #4597

Merged
merged 7 commits into from Apr 16, 2023

Conversation

TSRBerry
Copy link
Member

I thought this was added to master ages ago and didn't realize it was still missing.
Thank you to @shadowninja108 for making me aware of this.

This is almost 1:1 taken from the LDN build with some minor adjustments and the addition of the lan-interface-id parameter for Ryujinx.Headless.SDL2.

@TSRBerry TSRBerry added enhancement New feature or request gui Related to Ryujinx.Ui service:nifm Related to the nifm module (Ryujinx.HLE.HOS.Services.Nifm) labels Mar 25, 2023
@TSRBerry TSRBerry requested a review from a team April 1, 2023 17:43
Copy link
Member

@riperiperi riperiperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTK is unable to save the network interface. Make sure you test features on both UIs.

@TSRBerry
Copy link
Member Author

Sorry about that. It's fixed now!

Copy link
Member

@riperiperi riperiperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to see this ported over.

@TSRBerry TSRBerry enabled auto-merge (squash) April 16, 2023 14:59
@TSRBerry TSRBerry merged commit 69b6ef7 into Ryujinx:master Apr 16, 2023
6 checks passed
yeah-its-gloria pushed a commit to yeah-its-gloria/Ryujinx that referenced this pull request Apr 16, 2023
* Add network adapter dropdown from LDN build

* Ava: Add NetworkInterfaces to SettingsNetworkTab

* Add headless network interface option

* Add network interface dropdown to Avalonia

* Fix handling network interfaces without a gateway address

* gtk: Actually save selected network interface to config

* Increment config version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui Related to Ryujinx.Ui service:nifm Related to the nifm module (Ryujinx.HLE.HOS.Services.Nifm)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants