New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI] Add network interface dropdown #4597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTK is unable to save the network interface. Make sure you test features on both UIs.
e8d35f3
to
6d9809b
Compare
Sorry about that. It's fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice to see this ported over.
6d9809b
to
c7d6af2
Compare
* Add network adapter dropdown from LDN build * Ava: Add NetworkInterfaces to SettingsNetworkTab * Add headless network interface option * Add network interface dropdown to Avalonia * Fix handling network interfaces without a gateway address * gtk: Actually save selected network interface to config * Increment config version
I thought this was added to master ages ago and didn't realize it was still missing.
Thank you to @shadowninja108 for making me aware of this.
This is almost 1:1 taken from the LDN build with some minor adjustments and the addition of the lan-interface-id parameter for
Ryujinx.Headless.SDL2
.