Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU: Remove CPU region handle containers #4817

Merged
merged 2 commits into from
May 5, 2023
Merged

GPU: Remove CPU region handle containers #4817

merged 2 commits into from
May 5, 2023

Commits on May 5, 2023

  1. GPU: Remove CPU region handle containers. 

    Another one for the "I don't know why I didn't do this earlier" pile.

This removes the "Cpu" prefixed region handle classes, which each mirror a region handle type from Ryujinx.Memory.

Originally, not all projects had a reference to Ryujinx.Memory, so these classes were introduced to bridge the gap. Someone else crossed that bridge since, so these classes don't have much of a purpose anymore.

This PR replaces all uses of CpuRegionHandle etc to their direct Ryujinx.Memory versions.

RegionHandle methods (specifically QueryModified) are about the hottest path there is in the entire emulator, so there is a nice boost from doing this.
    @riperiperi
    riperiperi committed May 5, 2023
    Configuration menu
    Copy the full SHA
    9f51c0d View commit details
    Browse the repository at this point in the history

  2. Add docs

    @riperiperi
    riperiperi committed May 5, 2023
    Configuration menu
    Copy the full SHA
    0587e1e View commit details
    Browse the repository at this point in the history