time: Update for 15.0.0 changes and fixes long standing issues #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marysaka
added
enhancement
gdkchan
reviewed
May 5, 2023
Last time we did an upgrade on the time service was during 9.x era, it was about time to take back that reverse again! 15.0.0 added a new structure on the shared memory to get steady clock raw timepoints with a granularity in nanoseconds. This commit implements this new part. I plan to write a follow up with a bit of refactoring of this ancient part of the emulator. As always, reverse and work done by your truly. PS: As a reminder, if this change is reused anywhere else, work should be credited as Ryujinx and not my person.
This should fix local and network clock returning 0 under usage with shared memory. This probably fix #2430.
marysaka
force-pushed
the
feature/time-15.0.0
branch
from
93c4bb8
to
dc9df8c
Compare
…ock have a valid clock id
marysaka
force-pushed
the
feature/time-15.0.0
branch
from
3431dc0
to
5efa7d9
Compare
|
Testing with switch-examples: time In game time and prepo logs for ACNH were also always correct! So seems like everything is working fine! |
Fix Pokemon Sword Pokejobs for real.
marysaka
changed the title
gdkchan
approved these changes
May 7, 2023
AcK77
added a commit
to AcK77/Ryujinx
that referenced
this pull request
May 7, 2023
During testing of Ryujinx#4822, Mary pointed out the way we calculate time offset is wrong in our Avalonia UI. This PR fixed that. The axaml file is autoformatted too.
AcK77
approved these changes
May 7, 2023
AcK77
added a commit
that referenced
this pull request
May 7, 2023
* Ava: Fix SystemTimeOffset calculation During testing of #4822, Mary pointed out the way we calculate time offset is wrong in our Avalonia UI. This PR fixed that. The axaml file is autoformatted too. * DateTime.Now in local var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time we did an upgrade on the time service was during 9.x era, it was about time to take back that reverse again!
15.0.0 added a new structure on the shared memory to get steady clock raw timepoints with a granularity in nanoseconds.
This PR implements this new part.
I plan to write a follow up with a bit of refactoring of this ancient part of the emulator.
As always, reverse and work done by your truly.
This should also fix local and network clock returning 0 under usage with shared memory.
FIx #2430.
PS: As a reminder, if this change is reused anywhere else, work should be credited as Ryujinx and not my person.