Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amadeus: Fix wrong channel mapping check and an old typo #4888

Merged
merged 2 commits into from May 11, 2023

Conversation

marysaka
Copy link
Contributor

This was always going to happens, as a result quadratic would break and move index after the channel count point, effectively breaking input/output indices.

Fixes TOTK audio but also possible newer game using quadratic.

I also fixed an index issue on reverb 3d early delay.

PS: As a reminder, if this change is reused anywhere else, work should be credited as Ryujinx and not my person.

This was always going to happens, as a result quadratic would break and
move index after the channel count point, effectively breaking
input/output indices.
@marysaka marysaka added audio Related to Ryujinx.Audio fix Fix something labels May 11, 2023
@marysaka marysaka requested review from AcK77, gdkchan, riperiperi, TSRBerry and a team May 11, 2023 17:48
Copy link
Member

@IsaacMarovitz IsaacMarovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@marysaka marysaka enabled auto-merge (squash) May 11, 2023 18:13
@marysaka marysaka merged commit 40d47b7 into Ryujinx:master May 11, 2023
8 checks passed
@MutantAura MutantAura mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio Related to Ryujinx.Audio fix Fix something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants