Fix incorrect ASTC endpoint color when using LuminanceDelta mode #4890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riperiperi
approved these changes
May 11, 2023
marysaka
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug on the ASTC decoder that caused some ASTC texture to be corrupt and have white pixels where they shouldn't. Only affects GPUs that don't support ASTC natively (which is pretty much everything other than Apple Silicon and old Intel integrated GPUs).
Reference form the official decoder: https://github.com/ARM-software/astc-encoder/blob/0a3269f9de2b457dbeb7c5c6265e96c45b64647c/Source/astcenc_color_unquantize.cpp#L229
This fixes some texture corruption in The Legend of Zelda: Tears of the Kingdom.
Before:
After: