Enable explicit LOD for array textures with depth compare on SPIR-V #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdkchan
added
gpu
AcK77
approved these changes
May 11, 2023
riperiperi
approved these changes
May 11, 2023
jerome-cs
approved these changes
May 11, 2023
jewom
approved these changes
May 11, 2023
marysaka
approved these changes
May 11, 2023
|
Hello @gdkchan, the issue still exists for me. Vulkan Backend
|
|
That fixed it, thank you. |
noxifoxi
added a commit
to noxifoxi/Ryujinx
that referenced
this pull request
May 13, 2023
That was missing from Ryujinx#4892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes what I believe to be a leftover from the GLSL backend (before it started using the shadow LOD extension). It was forcing explicit LOD to be removed when using depth-comparison with array textures, since that is not supported on unextended GLSL. AFAIK that limitation does not exist on SPIR-V.
This fixes some glitches on The Legend of Zelda: Tears of the Kingdom when using the Vulkan backend (as it's the only backend that uses SPIR-V shaders right now).
Before:
After:
I recommend testing on AMD and making sure it doesn't break.