Remove barrier on Intel if control flow is potentially divergent

[gdkchan]

Apparently, having a barrier after return on a shader causes Intel GPUs to hang. As a work around, this change removes the barrier from the shader in those cases.

Allows The Legend of Zelda: Tears of the Kingdom to run on Intel GPUs.

However, from my tests it still crashes a few minutes later with DeviceLost error (apparently for a different reason?), so it would be nice to get testing on other Intel GPUs to see if the issue affects all of them.

[github-actions]

Download the artifacts for this pull request:

• ryujinx-Release-1.1.0+a18440b-linux_x64
• ryujinx-Release-1.1.0+a18440b-win_x64

Experimental GUI (Avalonia)

• ava-ryujinx-Release-1.1.0+a18440b-linux_x64
• ava-ryujinx-Release-1.1.0+a18440b-macos_universal
• ava-ryujinx-Release-1.1.0+a18440b-win_x64

GUI-less (SDL2)

• sdl2-ryujinx-headless-Release-1.1.0+a18440b-linux_x64
• sdl2-ryujinx-headless-Release-1.1.0+a18440b-win_x64

Only for Developers

• ava-ryujinx-Debug-1.1.0+a18440b-linux_x64
• ava-ryujinx-Debug-1.1.0+a18440b-macos_universal
• ava-ryujinx-Debug-1.1.0+a18440b-win_x64
• ryujinx-Debug-1.1.0+a18440b-linux_x64
• ryujinx-Debug-1.1.0+a18440b-win_x64
• sdl2-ryujinx-headless-Debug-1.1.0+a18440b-linux_x64
• sdl2-ryujinx-headless-Debug-1.1.0+a18440b-win_x64

[jvruyu]

Can confirm it allows the game to boot on a i5-1035G1 (ICL GT1) on Mesa 23.0.3 (Fedora), but it effectively crashes after a few minutes (don't think the log contains the error since it just hangs until the process' killed). Vulkan is desperately slow, almost unplayable, but OpenGL otherwise works just fine.

Ryujinx_1.1.0+2343f4d_2023-05-22_14-34-16.log

[2Tsk2]

Ryujinx_1.1.0+2343f4d_2023-05-22_22-02-13.log
works on an i5-8365u with a uhd620 igpu, crashes after a few mins.

[piplup55]

allows for the game to boot on intel arc with mesa but due to the slow drivers it's not really playable didn't see a deviceloss error in my 10 minutes of playing around, vulkan is slow like every other game on arc

Images

[riperiperi]

Looks reasonable if this is definitely invalid. I wonder why the shader has this tho, could the intention be to demote rather than return?

[shenef]

Ryujinx_1.1.0+2343f4d_2023-05-24_18-39-00.log
Crashed about a minute into the intro cutscene.
Running on Win11 with an Arc A770 16GB, extremely stable 30 fps (33.3x ms) on Vulkan.

OpenGL has much worse performance and graphical glitches but it runs, had one crash with it but on the second try it worked fine.
After progressing a bit with OpenGL, Vulkan works great but there seem to be situations that always crash it.

[jvruyu]

Can confirm it allows the game to boot on a i5-1035G1 (ICL GT1) on Mesa 23.0.3 (Fedora), but it effectively crashes after a few minutes (don't think the log contains the error since it just hangs until the process' killed). Vulkan is desperately slow, almost unplayable, but OpenGL otherwise works just fine.

Ryujinx_1.1.0+2343f4d_2023-05-22_14-34-16.log

Setting vm.max_map_count to a high value seems to stop the crashing but I can't really confirm, would make sense for the app to segfault rather than report a crash in that case, tho.

[Krusl9263]

Looks like the game crashes not only randomly on a Intel ARC graphics, but on some certain point like

Try to teleport to this shine will cause both yuzu and ryujinx to crash immediately. There're many crashing points like this on the map, especially on sky islands.

[shenef]

On driver version 4382 (which has this fix: IGCIT/Intel-GPU-Community-Issue-Tracker-IGCIT#159) with an Arc A770, this build has fixed all crashes for me.
As a control, the latest official release build still exhibits the same crashes as the older drivers.

[Krusl9263]

On driver version 4382 (which has this fix: IGCIT/Intel-GPU-Community-Issue-Tracker-IGCIT#159) with an Arc A770, this build has fixed all crashes for me. As a control, the latest official release build still exhibits the same crashes as the older drivers.

Well, there're still locations that crash ryujinx. Mostly on sky islands. See my comment above.

[gdkchan]

Unfortunately I don't think I can test this fix, I only have a UHD 630 integrate Intel GPU here, and apparently it's already out of support since the latest driver on their page is from last year. I don't think there is any harm in merging this though so I will mark it as ready for review.

[rookieplayi]

Unfortunately I don't think I can test this fix, I only have a UHD 630 integrate Intel GPU here, and apparently it's already out of support since the latest driver on their page is from last year. I don't think there is any harm in merging this though so I will mark it as ready for review.

isnt the latest driver from 4th may this year im using that because i have an 8th gen cpu

[jvruyu]

Hope this gets merged soon, would fix #4922 w/o any known setback. Further issues w/ Intel GPUs (and in general) can be looked up over time, but rn we Intel users are stuck on this somewhat older build, in order to boot up the game.

[rookieplayi]

On driver version 4382 (which has this fix: IGCIT/Intel-GPU-Community-Issue-Tracker-IGCIT#159) with an Arc A770, this build has fixed all crashes for me. As a control, the latest official release build still exhibits the same crashes as the older drivers.

Well, there're still locations that crash ryujinx. Mostly on sky islands. See my comment above.

crashes on the great sky islands my intel celeron n5100 intel uhd graphics is able to run it on ryujinx on this build the solution to the intro crash is switching to opengl and then save then reload the game with vulkan that works for me