Truncate vertex attribute format if it exceeds stride on MoltenVK #5094
+265
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdkchan
added
gpu
gdkchan
added
the
graphics-backend:vulkan
|
Download the artifacts for this pull request: Experimental GUI (Avalonia)GUI-less (SDL2)Only for Developers
|
|
The hero we all need but don't deserve <3 |
marysaka
approved these changes
May 25, 2023
|
Are we merging this to the nightly builds? |
riperiperi
approved these changes
May 25, 2023
They work with the Vulkan |
|
Hey, i'm trying to download it, but I'm not able to using the MacOS link or any other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zelda Tears of the Kingdom has a few cases where it uses a 4 components format instead of a 3 components format, but everything (offset, buffer stride) are calculated for a 3 components format, and the vertex shader also only accesses 3. The fact that it uses 4 causes the vertex attribute to exceed the stride in some cases. This is invalid and causes weird bugs on Metal.
It seems MoltenVK already has some code to work around this issue:
https://github.com/KhronosGroup/MoltenVK/blob/b3ae0f48d0170570e46c7b3a8bcd8278bb71f40e/MoltenVK/MoltenVK/GPUObjects/MVKPipeline.mm#L1311
However it does not take offset into account, only the format size, so it will only kick in for attributes with a offset of zero. This PR implements the same change on the emulator, but it also adds the offset to the size, so it applies to all cases where the attribute exceeds the stride, not just cases where the offset is 0 and there's no other attribute after.
Fixes vertex explosions on The Legend of Zelda: Tears of the Kingdom.
Before:
After:
Fixes vertex explosions reported on #4949.