Delete ResourceAccess #5626
Merged
Delete ResourceAccess #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
gpu
|
Download the artifacts for this pull request: Experimental GUI (Avalonia)GUI-less (SDL2)Only for Developers
|
riperiperi
approved these changes
Sep 5, 2023
tvoracek
pushed a commit
to tvoracek/Ryujinx
that referenced
this pull request
Oct 17, 2023
* Delete ResourceAccess * Set write flag for vertex/geometry as compute output buffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added it to allow us to know if a resource is written from the shader on the backend, however #4899 added a bool on
BufferRangethat serves the same purpose, making it redundant, so this PR removes theResourceAccessenum and all of its uses.I also set the
writebool to true now on theBufferRanges passed from vertex/geometry as compute where the buffers are modified from the shader. I don't think this makes any difference since those buffers are never modified from CPU, but it's technically the right thing to do.