Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable keyboard controller input while swkbd is open (foreground) (second attempt) #6808

Merged
merged 4 commits into from
May 17, 2024

Conversation

TSRBerry
Copy link
Member

Pretty much the same as #6646. This PR just includes a new commit which only clears the driver state if the driver isn't null.

Original PR description

This PR fixes #5625 by disabling the keyboard controller input while the swkbd applet is open.

[!WARNING]
This does not prevent keyboard controller inputs while the inline keyboard is active.


Thank you @music-discussion for figuring out the bug and describing it in the comments! It saved me quite some time and allowed me to create this PR quickly.

@github-actions github-actions bot added the gui Related to Ryujinx.Ui label May 15, 2024
@ryujinx-mako ryujinx-mako bot requested review from AcK77, emmauss and a team May 15, 2024 13:35
Copy link
Member

@riperiperi riperiperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine, though I don't have the game where the input is read with the keyboard open.

@gdkchan gdkchan merged commit 8f51938 into Ryujinx:master May 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Related to Ryujinx.Ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to play Stardew Valley because Software Keyboard prompt will not close
4 participants