Workaround bug on logic op with float framebuffer

[piplup55]

built on top of #6852 to add support for intel gpu's
NOTE: this won't fix the crashing on windows

fixes #6859

before:

after:

[github-actions]

Download the artifacts for this pull request:

• ryujinx-Release-1.1.0+ff69625-linux_arm64
• ryujinx-Release-1.1.0+ff69625-linux_x64
• ryujinx-Release-1.1.0+ff69625-macos_universal
• ryujinx-Release-1.1.0+ff69625-win_x64

Old GUI (GTK3)

• gtk-ryujinx-Release-1.1.0+ff69625-linux_arm64
• gtk-ryujinx-Release-1.1.0+ff69625-linux_x64
• gtk-ryujinx-Release-1.1.0+ff69625-win_x64

GUI-less (SDL2)

• sdl2-ryujinx-headless-Release-1.1.0+ff69625-linux_arm64
• sdl2-ryujinx-headless-Release-1.1.0+ff69625-linux_x64
• sdl2-ryujinx-headless-Release-1.1.0+ff69625-macos_universal
• sdl2-ryujinx-headless-Release-1.1.0+ff69625-win_x64

Only for Developers

• ryujinx-Debug-1.1.0+ff69625-linux_arm64
• sdl2-ryujinx-headless-Debug-1.1.0+ff69625-linux_arm64
• gtk-ryujinx-Debug-1.1.0+ff69625-linux_arm64
• ryujinx-Debug-1.1.0+ff69625-linux_x64
• sdl2-ryujinx-headless-Debug-1.1.0+ff69625-linux_x64
• gtk-ryujinx-Debug-1.1.0+ff69625-linux_x64
• ryujinx-Debug-1.1.0+ff69625-macos_universal
• sdl2-ryujinx-headless-Debug-1.1.0+ff69625-macos_universal
• ryujinx-Debug-1.1.0+ff69625-win_x64
• sdl2-ryujinx-headless-Debug-1.1.0+ff69625-win_x64
• gtk-ryujinx-Debug-1.1.0+ff69625-win_x64

[gdkchan]

Maybe it's better to enable it for all GPUs that are not NVIDIA.

[piplup55]

Maybe it's better to enable it for all GPUs that are not NVIDIA.

so we would enable it for nvidia only, i guess that makes more sense, i'm unware if it affects any other vendors

so something like this
bool logicOpEnable = LogicOpEnable && (gd.Vendor == Vendor.Nvidia || Internal.LogicOpsAllowed);
instead of
bool logicOpEnable = LogicOpEnable && (gd.Vendor != Vendor.Amd && gd.Vendor != Vendor.Intel || Internal.LogicOpsAllowed);

[gdkchan]

Maybe it's better to enable it for all GPUs that are not NVIDIA.

so we would enable it for nvidia only, i guess that makes more sense, i'm unware if it affects any other vendors

so something like this bool logicOpEnable = LogicOpEnable && (gd.Vendor == Vendor.Nvidia || Internal.LogicOpsAllowed); instead of bool logicOpEnable = LogicOpEnable && (gd.Vendor != Vendor.Amd && gd.Vendor != Vendor.Intel || Internal.LogicOpsAllowed);

Yes. Most of the other vendors are mobile vendors that don't even support logic ops at all. There's newer Adreno GPUs that supports it I think, and Samsung Xclipse GPUs, but I guess those would have the bug too since they are based on AMD RDNA architecture.

[piplup55]

Yes. Most of the other vendors are mobile vendors that don't even support logic ops at all. There's newer Adreno GPUs that supports it I think, and Samsung Xclipse GPUs, but I guess those would have the bug too since they are based on AMD RDNA architecture.

i'll make the change and test it on amd and intel, it should work in theory but just in case

[gdkchan]

lgtm, minus comment.