Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to netcoreapp3.0 & bump dependencies #318

Merged
merged 7 commits into from
Nov 14, 2019
Merged

Update to netcoreapp3.0 & bump dependencies #318

merged 7 commits into from
Nov 14, 2019

Conversation

kerams
Copy link
Contributor

@kerams kerams commented Oct 19, 2019

WIP

Content/Dockerfile Outdated Show resolved Hide resolved
"remotedev": "^0.2.9",
"sass": "^1.22.10",
"resolve-url-loader": "^3.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module not found: Error: Can't resolve 'resolve-url-loader' in 'C:\Users\admini\AppData\Local\Temp\2\e714f8fd321748de867231656baf5432'
 @ multi ./src/Client/Client.fsproj ./src/Client/style.scss app[1]

without this.

@kerams
Copy link
Contributor Author

kerams commented Oct 19, 2019

ERROR in ./.fable/Fable.Elmish.Streams.3.0.3/Program.fs
Module Error (from ./node_modules/fable-loader/index.js):
C:/Users/admini/AppData/Local/Temp/2/e714f8fd321748de867231656baf5432/.fable/Fable.Elmish.Streams.3.0.3/Program.fs(35,31):
(35,39) error FSHARP: The value, constructor, namespace or type 'mbStream' is not defined. (code 39)

Not sure what to do with this.

I can't run the tests fully, because they get stuck on

Error: listen EADDRINUSE: address already in use 0.0.0.0:8080
    at Server.setupListenHandle [as _listen2] (net.js:1298:14)
    at listenInCluster (net.js:1346:12)
    at doListen (net.js:1485:7)
    at processTicksAndRejections (internal/process/task_queues.js:81:21)
Emitted 'error' event on Server instance at:
    at emitErrorNT (net.js:1325:8)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) {
  code: 'EADDRINUSE',
  errno: 'EADDRINUSE',
  syscall: 'listen',
  address: '0.0.0.0',
  port: 8080
}

in between individual template permutation tests. Like it does not clean up properly.

@kerams
Copy link
Contributor Author

kerams commented Oct 19, 2019

At least Giraffe lock files are now lean and mean as expected ;).

@theimowski
Copy link
Member

ERROR in ./.fable/Fable.Elmish.Streams.3.0.3/Program.fs
Module Error (from ./node_modules/fable-loader/index.js):
C:/Users/admini/AppData/Local/Temp/2/e714f8fd321748de867231656baf5432/.fable/Fable.Elmish.Streams.3.0.3/Program.fs(35,31):
(35,39) error FSHARP: The value, constructor, namespace or type 'mbStream' is not defined. (code 39)

@dbrattli does it tell you anything?

@dbrattli
Copy link
Contributor

dbrattli commented Oct 22, 2019

@theimowski Yes, let me check. Looks like we need to limit FSharp.Control.AsyncRx to 1.1.0 in paket.dependencies, streams section

Fable.Elmish.Streams eventually needs to be replaced back to Fable.Reaction. I can see if I can find time for that next weekend.

@kerams
Copy link
Contributor Author

kerams commented Oct 23, 2019

Uh, any idea why it still restored 1.2.1 with FSharp.Control.AsyncRx ~> 1.1.0? I thought that mean < 1.2

@kerams
Copy link
Contributor Author

kerams commented Oct 23, 2019

Now 1.1 gets restored and compiled by Fable, but still no dice.

@dbrattli
Copy link
Contributor

Looks like we need to go back to ~> 1.0

@kerams
Copy link
Contributor Author

kerams commented Oct 23, 2019

Ok, that looks good now. On the other hand, Elmish.Bridge does not like the latest version of Fable.SimpleJson

So do we pin Fable.SimpleJson to 3.5 when used with Elmish.Bridge or fix the latter?

@theimowski
Copy link
Member

@Nhowka @Zaid-Ajaj can you help with that?

@theimowski
Copy link
Member

@kerams I'd say choose any option as long as it works - let's make this PR pass tests and then make decisions

@kerams kerams marked this pull request as ready for review October 29, 2019 06:50
@theimowski
Copy link
Member

Seems Travis timeouts - I decreased the number of tests to make it pass.
Let me review the changes and make some local tests now

ENTRYPOINT [ "./Server" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change? I get following error: standard_init_linux.go:211: exec user process caused "exec format error"

Copy link
Contributor Author

@kerams kerams Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET Core 3 should produce executables by default, so I thought this would be the way to launch it now.

It doesn't produce a dll for me during a regular build, but I haven't tried creating an image myself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually, I get both now. I suppose this line may be reverted then.

@kerams
Copy link
Contributor Author

kerams commented Nov 12, 2019

Elmish.Bridge has been updated, so the Fable.SimpleJson pin can be removed now.

@Nhowka
Copy link

Nhowka commented Nov 12, 2019

Sorry, I missed the notification. 😅

@theimowski
Copy link
Member

Ok it looks good to go for me now 👍 let's just wait for CI to pass and I'll merge it

@theimowski
Copy link
Member

Travis continues to timeout, however I was able to run it once successfully

I'll go and release this and take care of Travis afterwards

Thanks a lot @kerams and @dbrattli for contributing!

@theimowski theimowski merged commit d1d76e6 into SAFE-Stack:master Nov 14, 2019
@kerams kerams deleted the net3 branch November 14, 2019 15:18
@kerams
Copy link
Contributor Author

kerams commented Nov 14, 2019

My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants