-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to netcoreapp3.0 & bump dependencies #318
Conversation
"remotedev": "^0.2.9", | ||
"sass": "^1.22.10", | ||
"resolve-url-loader": "^3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module not found: Error: Can't resolve 'resolve-url-loader' in 'C:\Users\admini\AppData\Local\Temp\2\e714f8fd321748de867231656baf5432'
@ multi ./src/Client/Client.fsproj ./src/Client/style.scss app[1]
without this.
Not sure what to do with this. I can't run the tests fully, because they get stuck on
in between individual template permutation tests. Like it does not clean up properly. |
At least Giraffe lock files are now lean and mean as expected ;). |
@dbrattli does it tell you anything? |
@theimowski Yes, let me check. Looks like we need to limit
|
Uh, any idea why it still restored 1.2.1 with |
Now 1.1 gets restored and compiled by Fable, but still no dice. |
Looks like we need to go back to ~> 1.0 |
Ok, that looks good now. On the other hand, Elmish.Bridge does not like the latest version of Fable.SimpleJson So do we pin Fable.SimpleJson to 3.5 when used with Elmish.Bridge or fix the latter? |
@Nhowka @Zaid-Ajaj can you help with that? |
@kerams I'd say choose any option as long as it works - let's make this PR pass tests and then make decisions |
Seems Travis timeouts - I decreased the number of tests to make it pass. |
Content/Dockerfile
Outdated
ENTRYPOINT [ "./Server" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change? I get following error: standard_init_linux.go:211: exec user process caused "exec format error"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.NET Core 3 should produce executables by default, so I thought this would be the way to launch it now.
It doesn't produce a dll for me during a regular build, but I haven't tried creating an image myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or actually, I get both now. I suppose this line may be reverted then.
Elmish.Bridge has been updated, so the Fable.SimpleJson pin can be removed now. |
Sorry, I missed the notification. 😅 |
Ok it looks good to go for me now 👍 let's just wait for CI to pass and I'll merge it |
My pleasure. |
WIP