Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoth Fetch Fable dependency fails on Admin template #320

Closed
voronoipotato opened this issue Nov 7, 2019 · 6 comments
Closed

Thoth Fetch Fable dependency fails on Admin template #320

voronoipotato opened this issue Nov 7, 2019 · 6 comments

Comments

@voronoipotato
Copy link

voronoipotato commented Nov 7, 2019

ERROR in ./.fable/Thoth.Json.3.4.1/Encode.fs
Module Error (from ./node_modules/fable-loader/index.js):
C:/Users/awball/Documents/Projects/AssetMana/.fable/Thoth.Json.3.4.1/Encode.fs(437,28): (437,60) error FABLE: Cannot resolve System.Enum.GetUnderlyingType
 @ ./src/Client/Client.fs 58:0-171 300:115-121 300:228-233 300:335-342 305:25-77
 @ ./src/Client/Client.fsproj
 @ multi ./src/Client/Client.fsproj

I was able to get it to work by using a later version of fable-compiler. Looks like a lot of dependencies are old. I also updated the .netcore to 3.0 and things do work now but it looks like it fails out of the box.

@MangelMaxime
Copy link
Contributor

I just checked the template does work out the box. I think you upgraded the dependencies when doing the switch to .netcore to 3.0.

Out of the box, the template is using Thoth.Json (3.3).

However, I think the template should be upgraded to Thoth.Json 3.4 and the latest version of fable-compiler because not everyone knows that enum reflection API is a recent addition.

@voronoipotato
Copy link
Author

It works fine with 3.0, should we switch to it?

@theimowski
Copy link
Member

update to 3.0 is WIP #318

@theimowski
Copy link
Member

3.0 support has been released in v1.19 - can you check if it works now OOTB?

@voronoipotato
Copy link
Author

I'll have time this weekend :)

@theimowski
Copy link
Member

Closing - should no longer be an issue in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants