Add PA correction for NIRISS #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Set to None regardless of the reason
Could be that instrument is set to NIRISS but the data was simulated or modified. This will return 0.0 by default.
For both *parang functions and for the compute_pa() function
for more information, see https://pre-commit.ci
|
I added tests for SPHERE and AMI PA calculations. I think this is ready for review @DrSoulain. |
|
Had a quick look and I would also like to review this from a technical angle. Please ping me if I forget ! |
|
I'll probably just approve this next time, but I'd like to see #136 merged first |
neutrinoceros
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the function used for SPHERE to implement options for different instruments and added a function to compute it for NIRISS. This depends on #136, so marking as Draft for now.