Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PA correction for NIRISS #139

Merged
merged 15 commits into from
Aug 4, 2022
Merged

Add PA correction for NIRISS #139

merged 15 commits into from
Aug 4, 2022

Commits on May 25, 2022

  1. Add telescope and isntrument to raw oifits

    @vandalt
    vandalt committed May 25, 2022
    Configuration menu
    Copy the full SHA
    871242b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Refactor parang functions to use kwarg dict

    @vandalt
    vandalt committed May 27, 2022
    Configuration menu
    Copy the full SHA
    c32c5bc View commit details
    Browse the repository at this point in the history

  2. Add ROLL_REF parang for NIRISS

    @vandalt
    vandalt committed May 27, 2022
    Configuration menu
    Copy the full SHA
    9f92e20 View commit details
    Browse the repository at this point in the history

  3. Account for v3i_yang in for NIRISS

    @vandalt
    vandalt committed May 27, 2022
    Configuration menu
    Copy the full SHA
    eee4822 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    298e606 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Handle missing sci header in extraction function 

    Set to None regardless of the reason
    @vandalt
    vandalt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    bbb5f82 View commit details
    Browse the repository at this point in the history

  2. Handle when hdr is None in niriss_parang 

    Could be that instrument is set to NIRISS but the data was simulated or
modified. This will return 0.0 by default.
    @vandalt
    vandalt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    58e635a View commit details
    Browse the repository at this point in the history

  3. Add tests for PA calculations 

    For both *parang functions and for the compute_pa() function
    @vandalt
    vandalt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    4625db8 View commit details
    Browse the repository at this point in the history

  4. Ignore SCI header warnings in tests calling extract_bs

    @vandalt
    vandalt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    aacfb23 View commit details
    Browse the repository at this point in the history

  5. Add test fits data for NIRISS PA calculations

    @vandalt
    vandalt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    0837ba2 View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    40ec938 View commit details
    Browse the repository at this point in the history

  7. Make sci_hdr keyword-only in compute_pa

    @vandalt
    vandalt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    546bca5 View commit details
    Browse the repository at this point in the history

  8. Remove leftover TODO comments in PA tests

    @vandalt
    vandalt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    a740932 View commit details
    Browse the repository at this point in the history

  9. Update tests for keyword-only sci_hdr

    @vandalt
    vandalt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    389ff4e View commit details
    Browse the repository at this point in the history

  10. Add comments for pytest mark

    @vandalt
    vandalt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    7877cf4 View commit details
    Browse the repository at this point in the history