Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for TRIX reader #83

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Add support for TRIX reader #83

merged 2 commits into from
Jun 7, 2019

Conversation

GezimSejdiu
Copy link
Member

No description provided.

@GezimSejdiu GezimSejdiu added the RDF label Jun 7, 2019
@GezimSejdiu GezimSejdiu added this to the 0.6 milestone Jun 7, 2019
@GezimSejdiu GezimSejdiu requested a review from dgraux June 7, 2019 08:29
@coveralls
Copy link

coveralls commented Jun 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 219

  • 9 of 15 (60.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 34.217%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sansa-rdf-spark/src/main/scala/net/sansa_stack/rdf/spark/io/package.scala 9 15 60.0%
Files with Coverage Reduction New Missed Lines %
sansa-rdf-spark/src/main/scala/net/sansa_stack/rdf/spark/io/package.scala 1 64.29%
Totals Coverage Status
Change from base Build 217: 0.1%
Covered Lines: 1497
Relevant Lines: 4375
💛 - Coveralls

@GezimSejdiu GezimSejdiu requested a review from Aklakan June 7, 2019 09:10
Aklakan
Aklakan approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@Aklakan Aklakan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be duplication in checks of format characters ('i', 'j', 'k', etc) which should be cleaned up eventually, but this shouldn't be a blocking issue.

@Aklakan Aklakan merged commit 0f68375 into develop Jun 7, 2019
@GezimSejdiu GezimSejdiu deleted the feature/new-rdf-serialization-formats branch June 7, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aklakan Aklakan Aklakan approved these changes

@dgraux dgraux Awaiting requested review from dgraux

Assignees
No one assigned
Labels
RDF
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@GezimSejdiu @coveralls @Aklakan