SapMachine (11) #1550: Implement new malloc trace for SapMachine 11 #1745
+5,243
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… malloctrace2_sapmachine11
…p an entry, since code in CodeCache depends on it.
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
RealCLanger
changed the title
RealCLanger
reviewed
Jul 11, 2024
There was a problem hiding this comment.
What about this hunk which exists in sapmachine17. Why don't we need it in 11?
It also isn't guarded by #ifdefs in sapmachine21 and above.
Also, the build on linuxx86 failed.
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
…ce we can fail later instead.
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
RealCLanger
approved these changes
Jul 15, 2024
RealCLanger
reviewed
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly taken from the SAPJVM implementation, which is also based on JDK11.
fixes #1550