Feature request: Option to replace =,<,>,<=,>=,<> by EQ, LT, GT, LE, GE, NE

[mraht]

Currently there’s a rule replacing EQ, LT, GT, LE, GE, NE with =,<,>,<=,>=,<>. I'd like to have the reversed option, as I prefer the character-based comparison.

I know, a widely discussed topic, but SAP docu and clean abap just enforce the consistent use not the usage of either version.

[jmgrassau]

Hi Marius,

hm, yes, personally, I don't find EQ, LT, GT to be better readable at all (except maybe for the distinction between = as an assignment operator and EQ as a comparison operator, for which other programming languages have ==); but as far as I know, there is indeed only the recommendation by the ABAP Keyword Documentation to be consistent by using either one or the other set of operators.

So it shouldn't be too difficult to add an option to enable either direction (and rename the rule "Prefer =, <>, <= etc. to EQ, NE, LE etc." accordingly). I guess you'd just want to align this setting with your team to avoid edit wars…

Kind regards,
Jörg-Michael

[mraht]

Hi @jmgrassau,

I don't find EQ, LT, GT to be better readable at all (except maybe for the distinction between = as an assignment operator and EQ as a comparison operator, for which other programming languages have ==)

Yes, the '=' instead of '==' leads IMHO to some disadvantages (s. SAP/styleguides#282 (comment)) and that's why I prefer the character-based comparison - it's more consistent from my point of view.

So it shouldn't be too difficult to add an option to enable either direction

Great to hear that. :)

I guess you'd just want to align this setting with your team to avoid edit wars…

Yes, but I think that's the case with some other settings, too. Also we use the folders option to align the settings with eachother - very great feature! :)

I love the work you've already done so far with abap cleaner - keep it up! :)

[jmgrassau]

Hi Marius,

with the next release, the cleanup rule "Prefer =, <>, <= etc. to EQ, NE, LE etc." will be renamed to "Use consistent set of comparison operators" and allow to specify the preferred set of operators:

With the "textual" setting, you get:

Kind regards,
Jörg-Michael

[mraht]

Many thanks! :)

[jmgrassau]

Hi Marius,

thanks again for this idea – the new option is now included in version 1.16.0, which was just released!

Kind regards,
Jörg-Michael