Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Change obsolete relational operators to valid operators (like >< to <>) #283

Closed
ConjuringCoffee opened this issue Mar 28, 2024 · 5 comments
Assignees

Comments

@ConjuringCoffee
Copy link
Contributor

Hi Jörg-Michael, here's a small feature request: I'd like to automatically change >< to <>. Very low priority of course, but probably easy to implement. Thanks! :)

@ConjuringCoffee
Copy link
Contributor Author

ConjuringCoffee commented Mar 28, 2024

Relevant SAP help section: Obsolete Relational Operators

So the obsolete operators are: ><, =< and =>

@ConjuringCoffee ConjuringCoffee changed the title Feature request: Change >< to <> Feature request: Change obsolete relational operators to valid operators (like >< to <>) Mar 28, 2024
@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

I feel privileged to never have encountered those in real life… Good point, though. I think we could combine this idea with #273 and the existing rule "Prefer =, <>, <= etc. to EQ, NE, LE etc." and then rename the rule to something like "Use consistent set of comparison operators". This would align well with the recommendation "that only one or the other set of operators is used within the context of a program" from rel_exp - Binary Comparison Operators and the Use consistent spelling guideline.

Kind regards,
Jörg-Michael

@jmgrassau jmgrassau self-assigned this Apr 12, 2024
@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

with the next release, the renamed cleanup rule "Use consistent set of comparison operators" (previously, "Prefer =, <>, <= etc. to EQ, NE, LE etc.", cp. #273) will also include an option to replace obsolete comparison operators with the preferred variant (symbolic or textual):

image

image

Kind regards,
Jörg-Michael

@ConjuringCoffee
Copy link
Contributor Author

Thank you!

@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

thanks again for the idea – this enhancement is now included in version 1.16.0, which was just released!

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants