Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIAD] - Smooth out the structure of Custom tile and its properties #621

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

ViktoriaFreidel
Copy link
Contributor

We reduce a substructure of custom tiles to be in sync with DB definition and for better Layout control
and side effects

@ViktoriaFreidel
Copy link
Contributor Author

Could you help to understand and resolve compatibility check error? We change a sub structure, should we then use "formatVersion": "2" ? Or there is on other reason of errors? Thank you.

@albertmink
Copy link
Contributor

The Compatability Check helps to detect incompatible changes. It is however not 'required' and doesn't block merging.

Did you shipped the editor? If not, you might just ignore this check.

@ViktoriaFreidel
Copy link
Contributor Author

Currently we are in development phase and shipment of the editor not done yet.
I would to ask you for review.

Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM

@wurzka wurzka merged commit 17458fd into SAP:main Jul 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants