Fix UI bugs + new features + JS refactoring #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targetted issues
Fixes and new features
Re-scan a repo using the categories instead of RAW rules
It is now possible to re-scan the selected repo using the categories.
Re-scan a repo using the Force mode
A checkbox to decide whether to scan a repo using the Force mode or not has been added to the (re)scan window.
Search for repos using the search bar
The user can make use of the search bar on the main page to search for repos.
Filter discoveries based on their categories
It is now possible to filter categories based on their categories using the buttons on the top-left of the window.
(In this example, the user will only see the discoveries that are under the
access token
category; of course, clicking on it again will disable the filter)Javascript & Redundant code
The javascript code has been optimized: got rid of redundant code & refactored multiple parts of it.
Both the
repos
anddiscoveries
windows are making use of the samescan modal
, that said, I did collect all the code chunks that manage it within a newscanForm.js
file, in which are contained all the functions that are needed to exploit the scan widget.Future work
We may consider using web-components in a future PR.