Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI bugs + new features + JS refactoring #44

Merged
merged 3 commits into from
Sep 7, 2020

Conversation

alaabenfatma
Copy link
Contributor

Targetted issues

Fixes and new features

Re-scan a repo using the categories instead of RAW rules

It is now possible to re-scan the selected repo using the categories.

Re-scan a repo using the Force mode

A checkbox to decide whether to scan a repo using the Force mode or not has been added to the (re)scan window.

Search for repos using the search bar

The user can make use of the search bar on the main page to search for repos.

Filter discoveries based on their categories

It is now possible to filter categories based on their categories using the buttons on the top-left of the window.
image
(In this example, the user will only see the discoveries that are under the access token category; of course, clicking on it again will disable the filter)

Javascript & Redundant code

The javascript code has been optimized: got rid of redundant code & refactored multiple parts of it.
Both the repos and discoveries windows are making use of the same scan modal, that said, I did collect all the code chunks that manage it within a new scanForm.js file, in which are contained all the functions that are needed to exploit the scan widget.

Future work

We may consider using web-components in a future PR.

@marcorosa marcorosa merged commit adce3d0 into SAP:develop Sep 7, 2020
@marcorosa marcorosa mentioned this pull request Sep 16, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants