fix: (platform) addressed list header label issue (#3457)

* fix to issues 3266 * fix to list issue 3423 added new line at end of the file fix icons in button breaking because of latest 0.12 * rebase with 3400 changess
SAP · Oct 1, 2020 · 584392f · 584392f
1 parent f8703ea
commit 584392f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 22 deletions.
diff --git a/.../platform-list/platform-list-examples/platform-list-with-selection-example.component.html b/.../platform-list/platform-list-examples/platform-list-with-selection-example.component.html
@@ -1,6 +1,6 @@
 <h3>Cozy Mode</h3>
 <fd-toolbar fdType="info" active="true">
-    <label fd-toolbar-label>({{_selectedItems.length}}) Items selected</label>
+    <label fd-toolbar-label>{{_selectedItems.length}} : Items selected</label>
 </fd-toolbar>
 <fdp-list noBorder="true" [dataSource]="_dataSource" selectionMode="multi" [(ngModel)]="_selectedItems"
     (selectedItemChange)="_showItemInfo($event)" selection="true">

diff --git a/...dard-list-item-examples/platform-standard-list-item-with-selection-example.component.html b/...dard-list-item-examples/platform-standard-list-item-with-selection-example.component.html
@@ -1,5 +1,5 @@
 <fd-toolbar fdType="info" active="true">
-    <label fd-toolbar-label>({{_selectedItems.length}}) Items selected</label>
+    <label fd-toolbar-label>{{_selectedItems.length}} : Items selected</label>
 </fd-toolbar>
 <fdp-list selection="true" [dataSource]="_dataSource" selectionMode="multi" [(ngModel)]="_selectedItems"
     (selectedItemChange)="_showItemInfo($event)" [hasByLine]="true">

diff --git a/libs/platform/src/lib/components/list/base-list-item.ts b/libs/platform/src/lib/components/list/base-list-item.ts
@@ -169,15 +169,6 @@ export class BaseListItem extends BaseComponent implements OnInit, AfterViewChec
         this.link = value;
     }
 
-    /**
-    * content Density of element. 'cozy' | 'compact'
-    */
-    @Input()
-    set contentDensity(contentDensity: ContentDensity) {
-        this._contentDensity = contentDensity;
-        this._isCompact = contentDensity === 'compact';
-    }
-
     /**Getter and setter the list of items */
     @Input()
     set item(item: any) {

diff --git a/libs/platform/src/lib/components/list/list.component.ts b/libs/platform/src/lib/components/list/list.component.ts
@@ -67,7 +67,7 @@ export class ListComponent extends CollectionBaseInput implements OnInit, AfterV
 
     /**Items to be loaded at once */
     @Input()
-    itemSize: number;
+    itemSize = 0;
 
     /**Enables lazy loadMore of data */
     @Input()
@@ -126,15 +126,6 @@ export class ListComponent extends CollectionBaseInput implements OnInit, AfterV
         }
     }
 
-    /**
-   * content Density of element. 'cozy' | 'compact'
-   */
-    @Input()
-    set contentDensity(contentDensity: ContentDensity) {
-        this._contentDensity = contentDensity;
-        this._isCompact = contentDensity === 'compact';
-    }
-
     /** setter and getter for _navigated */
     @Input('navigated')
     get navigated(): boolean {
@@ -179,6 +170,14 @@ export class ListComponent extends CollectionBaseInput implements OnInit, AfterV
         super.setValue(value);
     }
 
+    /**
+   * content Density of element. 'cozy' | 'compact'
+   */
+    set contentDensity(contentDensity: ContentDensity) {
+        this._contentDensity = contentDensity;
+        this._isCompact = contentDensity === 'compact';
+    }
+
     /** @hidden */
     @Output()
     selectedItemChange: EventEmitter<SelectionChangeEvent> = new EventEmitter<SelectionChangeEvent>();
@@ -394,7 +393,6 @@ export class ListComponent extends CollectionBaseInput implements OnInit, AfterV
         }
     }
 
-
     /** @hidden */
     /**handline keyboard operations
     * in template on list and list items