fix: (platform) addressed list header label issue #3457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sKudum
changed the title
|
Deploy preview for fundamental-ngx ready! Built with commit 6306c37 |
sKudum
force-pushed
the
fix/listissues
branch
2 times, most recently
from
a5e0ecf
to
ce6451e
Compare
sKudum
requested review from
JKMarkowski,
KevinOkamoto and
fkolar
and removed request for
JKMarkowski
|
LGTM, but could you wait until #3400 is merged? So you would be able to just put |
sKudum
force-pushed
the
fix/listissues
branch
from
ce6451e
to
de948a4
Compare
Hi @JKMarkowski , Updated with 3400. |
JKMarkowski
approved these changes
Oct 1, 2020
added new line at end of the file fix icons in button breaking because of latest 0.12
Closed
AntonOlkhovskyi
pushed a commit
to AntonOlkhovskyi/fundamental-ngx
that referenced
this pull request
Nov 16, 2020
* fix to issues 3266 * fix to list issue 3423 added new line at end of the file fix icons in button breaking because of latest 0.12 * rebase with 3400 changess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
#3423
#3266
#3416
Please provide a brief summary of this pull request.
labels with special characters in toolbar are not supported in rtl to ltr mode. So removed special charters in the label text as per current toolbar styles support.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist: