Skip to content

Commit

Permalink
feat: Remove usage of segmented button in docs (#3209)
Browse files Browse the repository at this point in the history
* docs: Remove usage of segmented button in docs

BREAKING CHANGES: Remove segmented button directive
  • Loading branch information
JKMarkowski committed Sep 9, 2020
1 parent 1cf4b79 commit ed2f058
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 168 deletions.
2 changes: 1 addition & 1 deletion apps/docs/src/app/core/api-files.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const API_FILES = {
breadcrumb: ['BreadcrumbComponent', 'BreadcrumbItemDirective', 'BreadcrumbLinkDirective'],
busyIndicator: ['BusyIndicatorComponent'],
button: ['ButtonComponent'],
segmentedButton: ['SegmentedButtonComponent', 'SegmentedButtonDirective'],
segmentedButton: ['SegmentedButtonComponent'],
calendar: [
'CalendarComponent',
'CalendarDayViewComponent',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,28 +33,28 @@ export class CustomI18nMomentCalendar extends CalendarI18n {
selector: 'fd-calendar-i18n-moment-example',
template: ` <label fd-form-label for="language">Select language:</label>
<fd-segmented-button id="language" style="margin-bottom:20px">
<button fd-segmented-button [size]="'xs'" (click)="setLocale('en-gb')" [state]="isSelected('en-gb')">
<button fd-button (click)="setLocale('en-gb')" [class]="isSelected('en-gb')">
English
</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('fr')" [state]="isSelected('fr')">
<button fd-button (click)="setLocale('fr')" [class]="isSelected('fr')">
French
</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('de')" [state]="isSelected('de')">
<button fd-button (click)="setLocale('de')" [class]="isSelected('de')">
German
</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('es')" [state]="isSelected('es')">
<button fd-button (click)="setLocale('es')" [class]="isSelected('es')">
Spanish
</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('bg')" [state]="isSelected('bg')">
<button fd-button (click)="setLocale('bg')" [class]="isSelected('bg')">
Bulgarian
</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('zh-cn')" [state]="isSelected('zh-cn')">
<button fd-button (click)="setLocale('zh-cn')" [class]="isSelected('zh-cn')">
Chinese CN
</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('zh-hk')" [state]="isSelected('zh-hk')">
<button fd-button (click)="setLocale('zh-hk')" [class]="isSelected('zh-hk')">
Chinese HK
</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('zh-tw')" [state]="isSelected('zh-tw')">
<button fd-button (click)="setLocale('zh-tw')" [class]="isSelected('zh-tw')">
Chinese TW
</button>
</fd-segmented-button>
Expand All @@ -76,7 +76,7 @@ export class CalendarI18nMomentExampleComponent {
}

isSelected(language: string): string {
return moment.locale() === language ? 'selected' : '';
return moment.locale() === language ? 'is-selected' : '';
}

setLocale(language: string): void {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<label fd-form-label>Languages</label>
<fd-segmented-button id="language" style="margin-bottom: 20px;">
<button fd-segmented-button [size]="'xs'" (click)="setLocale('en-gb')" [state]="isSelected('en-gb')">
<button fd-button (click)="setLocale('en-gb')" [class]="isSelected('en-gb')">
English
</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('fr')" [state]="isSelected('fr')">French</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('de')" [state]="isSelected('de')">German</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('bg')" [state]="isSelected('bg')">Bulgarian</button>
<button fd-segmented-button [size]="'xs'" (click)="setLocale('pl')" [state]="isSelected('pl')">Polish</button>
<button fd-button (click)="setLocale('fr')" [class]="isSelected('fr')">French</button>
<button fd-button (click)="setLocale('de')" [class]="isSelected('de')">German</button>
<button fd-button (click)="setLocale('bg')" [class]="isSelected('bg')">Bulgarian</button>
<button fd-button (click)="setLocale('pl')" [class]="isSelected('pl')">Polish</button>
</fd-segmented-button>

<br />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ export class DatePickerComplexI18nExampleComponent {
}

public isSelected(momentJsLang: string): string {
return this.actualMomentJsLang === momentJsLang ? 'selected' : '';
return this.actualMomentJsLang === momentJsLang ? 'is-selected' : '';
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ export class CustomI18nLabels extends CalendarI18nLabels {
template: `
<label fd-form-label for="language">Select language:</label>
<fd-segmented-button id="language" style="margin-bottom:20px">
<button fd-segmented-button [size]="'xs'" (click)="setFrench()" [state]="isSelected('fr')">French</button>
<button fd-segmented-button [size]="'xs'" (click)="setGerman()" [state]="isSelected('de')">German</button>
<button fd-segmented-button [size]="'xs'" (click)="setBulgarian()" [state]="isSelected('bg')">
<button fd-button (click)="setFrench()" [class]="isSelected('fr')">French</button>
<button fd-button (click)="setGerman()" [class]="isSelected('de')">German</button>
<button fd-button (click)="setBulgarian()" [class]="isSelected('bg')">
Bulgarian
</button>
</fd-segmented-button>
Expand Down Expand Up @@ -160,13 +160,13 @@ export class DatePickerI18nExampleComponent implements AfterViewInit {
isSelected(language: string): string {
switch (language) {
case 'fr': {
return this.selected === 1 ? 'selected' : '';
return this.selected === 1 ? 'is-selected' : '';
}
case 'de': {
return this.selected === 2 ? 'selected' : '';
return this.selected === 2 ? 'is-selected' : '';
}
case 'bg': {
return this.selected === 3 ? 'selected' : '';
return this.selected === 3 ? 'is-selected' : '';
}
}
}
Expand Down
1 change: 0 additions & 1 deletion libs/core/src/lib/segmented-button/public_api.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
export * from './segmented-button.module';
export * from './segmented-button.component';
export * from './segmented-button.directive';
Empty file.
Empty file.

This file was deleted.

71 changes: 0 additions & 71 deletions libs/core/src/lib/segmented-button/segmented-button.directive.ts

This file was deleted.

5 changes: 2 additions & 3 deletions libs/core/src/lib/segmented-button/segmented-button.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';

import { SegmentedButtonComponent } from './segmented-button.component';
import { SegmentedButtonDirective } from './segmented-button.directive';

@NgModule({
imports: [CommonModule],
exports: [SegmentedButtonComponent, SegmentedButtonDirective],
declarations: [SegmentedButtonComponent, SegmentedButtonDirective]
exports: [SegmentedButtonComponent],
declarations: [SegmentedButtonComponent]
})
export class SegmentedButtonModule {}

0 comments on commit ed2f058

Please sign in to comment.