Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove usage of segmented button in docs #3209

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Sep 7, 2020

Please provide a link to the associated issue.

part of #3085

Please provide a brief summary of this pull request.

There is removed old deprecated segmented button directive usage in docs and removed segmented-button.directive
BREAKING CHANGE: Remove segmented button directive

@JKMarkowski JKMarkowski added core Core library specific issues 0.22.0 labels Sep 7, 2020
@JKMarkowski JKMarkowski added this to the Sprint 45 - Berlin milestone Sep 7, 2020
@JKMarkowski JKMarkowski requested a review from a team September 7, 2020 09:50
@JKMarkowski JKMarkowski self-assigned this Sep 7, 2020
@JKMarkowski JKMarkowski added this to In progress in Development via automation Sep 7, 2020
@netlify
Copy link

netlify bot commented Sep 7, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 055a00c

https://deploy-preview-3209--fundamental-ngx.netlify.app

Copy link
Contributor

@salarenko salarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you also remove SegmentedButtonDirective?

@JKMarkowski JKMarkowski changed the title docs: Remove usage of segmented button in docs feat: Remove usage of segmented button in docs Sep 8, 2020
Development automation moved this from In progress to Reviewer approved Sep 8, 2020
@JKMarkowski JKMarkowski merged commit ed2f058 into master Sep 9, 2020
Development automation moved this from Reviewer approved to Done Sep 9, 2020
@JKMarkowski JKMarkowski deleted the docs/segmented-button-usage branch September 9, 2020 07:44
Lokanathan-k pushed a commit that referenced this pull request Sep 14, 2020
fix: programmatically click product menu item on space/enter and add keyboard arrow navigation (#3187)

* programmatically click product menu item on space/enter

* arrow key support for product switch

* start tests

* tests

* address pr comments

chore(release): version 0.22.0-rc.37 build 11487 [ci skip]

chore(core): minor docs examples improvements (#3215)

* chore(core) Imprive checkbox documentation

* chore(core) Improve radio-button documentation

* chore(core) Bring back crash notice

chore(release): version 0.22.0-rc.38 build 11490 [ci skip]

feat: Remove usage of segmented button in docs (#3209)

* docs: Remove usage of segmented button in docs

BREAKING CHANGES: Remove segmented button directive

chore(release): version 0.22.0-rc.39 build 11495 [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants