Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more match options with search-input component #456

Closed
cstechfoodie opened this issue Jan 25, 2019 · 1 comment
Closed

Support more match options with search-input component #456

cstechfoodie opened this issue Jan 25, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@cstechfoodie
Copy link

Feature requests

Feature request details

Currently, the search-input component only has one pipe function to match the prefix of string with input. However, this is not alway the case we want. We also need to have a pipe function to match the substring of a string with input, no matter what index the substring starts at. This helps much with filtering ids whose prefix are the same.

affected current version

Below are source code

https://github.com/SAP/fundamental-ngx/blob/develop/library/src/lib/search-input/search-input.component.ts

https://github.com/SAP/fundamental-ngx/blob/develop/library/src/lib/search-input/search-input.component.html

Is there anything else we should know?

It is nice to provide multiple pipe options and let user to chose which pipe function to use.

@MattL75 MattL75 added the enhancement New feature or request label Jan 25, 2019
@cstechfoodie
Copy link
Author

And maybe an option to disable the DropdownValues to be added

@MattL75 MattL75 self-assigned this Jan 28, 2019
mikerodonnell89 pushed a commit that referenced this issue Jan 31, 2019
* #456 #458 Added glyph option and made search-input usable with custom filter

* made background switching less abrupt

* button on search input should close regardless of glyph
@MattL75 MattL75 closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants