Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search-Input option for glyph #458

Closed
jakeleesap opened this issue Jan 25, 2019 · 5 comments
Closed

Search-Input option for glyph #458

jakeleesap opened this issue Jan 25, 2019 · 5 comments
Assignees
Labels
contribution welcome this fix/enhancement is approved and you are invited to contribute to it enhancement New feature or request good first issue Good for newcomers

Comments

@jakeleesap
Copy link

Can you please support the option to use another icon in search-input for glyph ?

thanks

@MattL75 MattL75 added enhancement New feature or request good first issue Good for newcomers contribution welcome this fix/enhancement is approved and you are invited to contribute to it labels Jan 25, 2019
@droshev
Copy link
Contributor

droshev commented Jan 27, 2019

@jakeleesap what is your scenario or use case?

@jakeleesap
Copy link
Author

Hi,
Base on our UX design, this field is default as a drop down with a default list, until the user type in any value, it will do a round trip to search the value. So, since the original drop down has already contains a list, it should allow us to default the icon as a Arrow-Down so the user would first click on it. Hope my explanation clear :(

@MattL75
Copy link
Contributor

MattL75 commented Jan 28, 2019

I'm not sure I completely understand what it is you're trying to do, but if the baseline requirement is control over the icon in search-input, I'm sure we can accommodate.

We can still have the search icon as default, so adding the option to change it will only make the component more flexible.

@MattL75 MattL75 self-assigned this Jan 28, 2019
@jakeleesap
Copy link
Author

Thanks for the response, maybe I explain once more time that is more simple.

Lets say I have many other field that I used "arrow-down" from glyph - and if I want to be consistent for the same field like "arrow-down" instead of the default "search" icon, it would nice to have the same icon.

thanks

mikerodonnell89 pushed a commit that referenced this issue Jan 31, 2019
* #456 #458 Added glyph option and made search-input usable with custom filter

* made background switching less abrupt

* button on search input should close regardless of glyph
@MattL75
Copy link
Contributor

MattL75 commented Jan 31, 2019

Hi @jakeleesap control over the search input icon will be available in the next release which will hopefully be soon! :)

@MattL75 MattL75 closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome this fix/enhancement is approved and you are invited to contribute to it enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants