Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add examples for usage of fd-components in forms #677

Closed
MattL75 opened this issue Apr 4, 2019 · 2 comments · Fixed by #860, #926 or #944
Closed

docs: add examples for usage of fd-components in forms #677

MattL75 opened this issue Apr 4, 2019 · 2 comments · Fixed by #860, #926 or #944
Assignees
Labels
documentation There is an issue with documentation good first issue Good for newcomers
Projects

Comments

@MattL75
Copy link
Contributor

MattL75 commented Apr 4, 2019

Is this a bug, enhancement, or feature request?

Documentation enhancement

Briefly describe your proposal.

We currently don't have any examples on how to use our components inside reactive or template-driven forms. We should address this.

@MattL75 MattL75 added the documentation There is an issue with documentation label Apr 4, 2019
@mikerodonnell89
Copy link
Member

@MattL75 Do you think this should go under the "Form" component section or should we start a new section for tutorials? Maybe it could go in the "Getting started" section as well...

@MattL75
Copy link
Contributor Author

MattL75 commented Apr 5, 2019

As a user, I'd want it to be in the examples of the component I'm looking to use inside a form. I say we add an example to the individual pages labeled as something along the lines of "Forms Usage" or like "Forms Support". When we have a table of contents on the side, it'll be easy for users to find what they're looking for.

@MattL75 MattL75 added the contribution welcome this fix/enhancement is approved and you are invited to contribute to it label Apr 13, 2019
@MattL75 MattL75 added good first issue Good for newcomers and removed contribution welcome this fix/enhancement is approved and you are invited to contribute to it labels May 22, 2019
@DorinR DorinR self-assigned this May 29, 2019
DorinR added a commit that referenced this issue May 30, 2019
DorinR added a commit that referenced this issue May 30, 2019
DorinR added a commit that referenced this issue Jun 4, 2019
* #677 Added example for using forms

* lock experimentation

* fixing package lock issue

* #677 Updated description for form group input component documentation

* #677 fixed minor formatting issue in documentation module
@DorinR DorinR reopened this Jun 4, 2019
DorinR added a commit that referenced this issue Jun 6, 2019
@DorinR DorinR reopened this Jun 6, 2019
DorinR added a commit that referenced this issue Jun 12, 2019
@droshev droshev added this to the sprint 13 - Hot Pie milestone Jun 14, 2019
DorinR added a commit that referenced this issue Jun 14, 2019
DorinR added a commit that referenced this issue Jun 14, 2019
DorinR added a commit that referenced this issue Jun 20, 2019
* #677 added example of date-picker being used in a reactive form

* #677 refactored template to be included in the ts file

* #677 refactored to initialize datepicker with today's date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment