New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added example of date-picker being used in a reactive form #944
Conversation
Deploy preview for fundamental-ngx ready! Built with commit 3732d9e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix merge conflicts? Also in keeping with the rest of the datepicker example source, the template can be just inline in the component definition
<fd-date-picker formControlName="date"></fd-date-picker> | ||
</form> | ||
|
||
Selected Date: {{ customForm.controls.date.value.date | date: 'fullDate' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be: Selected Date: {{ customForm.controls.date.value.date ? customForm.controls.date.value.date : 'null' }}
}) | ||
export class DatePickerFormExampleComponent { | ||
customForm = new FormGroup({ | ||
date: new FormControl('') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be date: new FormControl({date: null})
Please provide a link to the associated issue.
fixes #677
Please provide a brief summary of this pull request.
Adds another example to the date-picker component in the documentation (using angular reactive forms)
If this is a new feature, have you updated the documentation?
Not necessary