Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added example of date-picker being used in a reactive form #944

Merged
merged 4 commits into from Jun 20, 2019

Conversation

DorinR
Copy link
Contributor

@DorinR DorinR commented Jun 17, 2019

Please provide a link to the associated issue.

fixes #677

Please provide a brief summary of this pull request.

Adds another example to the date-picker component in the documentation (using angular reactive forms)

If this is a new feature, have you updated the documentation?

Not necessary

@netlify
Copy link

netlify bot commented Jun 17, 2019

Deploy preview for fundamental-ngx ready!

Built with commit 3732d9e

https://deploy-preview-944--fundamental-ngx.netlify.com

@droshev droshev added this to In progress in Development via automation Jun 17, 2019
@droshev droshev added this to the sprint 14 milestone Jun 17, 2019
Development automation moved this from In progress to Review in progress Jun 19, 2019
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix merge conflicts? Also in keeping with the rest of the datepicker example source, the template can be just inline in the component definition

<fd-date-picker formControlName="date"></fd-date-picker>
</form>

Selected Date: {{ customForm.controls.date.value.date | date: 'fullDate' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be: Selected Date: {{ customForm.controls.date.value.date ? customForm.controls.date.value.date : 'null' }}

})
export class DatePickerFormExampleComponent {
customForm = new FormGroup({
date: new FormControl('')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be date: new FormControl({date: null})

Development automation moved this from Review in progress to Reviewer approved Jun 20, 2019
@DorinR DorinR merged commit 647fcc4 into master Jun 20, 2019
Development automation moved this from Reviewer approved to Done Jun 20, 2019
@droshev droshev deleted the date-picker-form branch June 23, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add examples for usage of fd-components in forms
3 participants