Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Multi-input revisit #7611

Closed
4 tasks
droshev opened this issue Jan 25, 2022 · 1 comment
Closed
4 tasks

Core Multi-input revisit #7611

droshev opened this issue Jan 25, 2022 · 1 comment
Assignees
@droshev
Labels
core Core library specific issues denoland enhancement New feature or request TBD
Projects
Development

Comments

@droshev
Copy link
Contributor

droshev commented Jan 25, 2022

Is this a bug, enhancement, or feature request?

bugs and enhancements

Briefly describe your proposal.

transfer from #7587

  • Multi-input - revisit the keyboard - TBD
  • Multi-input: this PR allows the user to tab to the expand key to open the dropdown of selectable options. However the user then must shift+tab back to the input part of the multi-input, then press tab, to focus the first item in the list. Instead we should have an additional tab keypress, or down arrow press, focus the first item in the dropdown
  • Multi-input: both the checkbox and the entire list item receive tab focus
  • Multi-input (core): adding new tokens example. Type a new token and submit it with the enter key. The token is not added to the tokenizer and when opening the dropdown, is not visible in the list. However you will notice the token has been added to the total count (the "View All" count as increased) and the new item has been added next to the "Selected:" text.

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

latest
@droshev droshev added enhancement New feature or request core Core library specific issues denoland TBD labels Jan 25, 2022
@droshev droshev self-assigned this Jan 25, 2022
@droshev droshev added this to Backlog in Development via automation Jan 25, 2022
@droshev droshev mentioned this issue Jan 25, 2022
Closed
Mohammadreza-Mohammadi added a commit to Mohammadreza-Mohammadi/fundamental-ngx that referenced this issue Feb 9, 2022
@Mohammadreza-Mohammadi
fix(core): solve multi input add new token
3a39fcf 
dont add token that user type in input and then enter where the option is exist in optionslist and just select it.

SAP#7611
Merged
droshev pushed a commit that referenced this issue Feb 11, 2022
@Mohammadreza-Mohammadi
fix(core): solve multi input add new token (#7714)
66b49f0 
* fix(core): solve multi input add new token

dont add token that user type in input and then enter where the option is exist in optionslist and just select it.

#7611

* fix(core): handle empty string onsubmit method

onsubmit method handle empty searchTerm and just return
@droshev droshev mentioned this issue Nov 22, 2022
Closed
6 tasks
@droshev
Copy link
Contributor Author

droshev commented Nov 22, 2022

moved to #8985

@droshev droshev closed this as completed Nov 22, 2022
Development automation moved this from Backlog to Done Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droshev droshev

Labels
core Core library specific issues denoland enhancement New feature or request TBD
Projects
No open projects
Development
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@droshev