fix(core): solve multi input add new token #7714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dont add token that user type in input and then enter where the option is exist in optionslist and just select it. SAP#7611
|
|
|
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 4549ba6 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/6205208a56c85400086ac6a0 😎 Browse the preview: https://deploy-preview-7714--fundamental-ngx.netlify.app |
|
Hi @Mohammadreza-Mohammadi thank you for your contribution. Please sign the CLA so we can merge your PR. Thank you! |
|
I did it. |
platon-rov
reviewed
Feb 10, 2022
onsubmit method handle empty searchTerm and just return
|
Thanks @platon-rov , |
Mohammadreza-Mohammadi
requested review from
platon-rov
and removed request for
a team
platon-rov
approved these changes
Feb 11, 2022
droshev
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user type in input and then press enter to select option or add new token.
Related Issue(s)
this commit resolve one of issue in this #7611
if token is new and user allow to add new token and token is not exist in current list then user by pressing enter can add the new token to tokenlist.
if the token exist in list so user by pressing enter can add it to token list.
closes
Description
_onsubmit method check this behavior for adding token.