feat(core): shellbar horizon update #10275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N1XUS
changed the base branch from
fundamental-styles-update
to
fundamental-style-update-rebased
N1XUS
force-pushed
the
feat/9852-shellbar-update
branch
from
0618074
to
2d94af3
Compare
|
Visit the preview URL for this PR (updated for commit 2465cfa): https://fundamental-ngx-gh--pr10275-feat-9852-shellbar-u-anws14bl.web.app (expires Sun, 06 Aug 2023 14:41:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
mikerodonnell89
approved these changes
Aug 8, 2023
N1XUS
merged commit 28eef27
into
fundamental-style-update-rebased
16 of 17 checks passed
N1XUS
added a commit
that referenced
this pull request
Aug 9, 2023
* feat(core): shellbar horizon update * fix(core): fix unit tests
g-cheishvili
pushed a commit
that referenced
this pull request
Aug 15, 2023
* feat(core): shellbar horizon update * fix(core): fix unit tests
g-cheishvili
pushed a commit
that referenced
this pull request
Aug 17, 2023
* feat(core): shellbar horizon update * fix(core): fix unit tests
N1XUS
added a commit
that referenced
this pull request
Aug 21, 2023
* feat(core): shellbar horizon update * fix(core): fix unit tests
N1XUS
added a commit
that referenced
this pull request
Aug 22, 2023
* chore: adopted radio button changes (#9950) * chore(core): removed todo for popover body after fd-styles update * fix(core,platform): removed some todos * feat(core): list horizon update. added secondary list item type support (#9992) * chore: latest fd-styles rc update * chore: adopted radio button changes (#9950) * chore(deps): update to the latest fd-styles release * chore(core): removed todo for popover body after fd-styles update * feat(core): added list secondary item types * fix(e2e): fixed e2e test for list byline * chore: added examples for secondary types * chore: got rid of unused variables * chore(core): updated card to latest styles modifications * feat(core): message strip horizon (#10067) * feat(core,docs): added message strip indication color and custom icon support * feat(docs): added message strip custom icon small example * fix(docs): fixed documentation missing files * fix(e2e,docs): moved custom icon example to separate example file * feat(core): added wrapping to the checkbox label (#10091) * feat(core): added wrapping to the checkbox label * chore(core): fixed jsdocs * fix(e2e): fixed e2e tests for checkbox * feat(core): busy indicator horizon (#10066) * feat(core): busy indicator standalone migration * feat(core): link standalone migration * feat: i18n module standalone migration * feat(core): text component standalone migration * feat(cdk): added auto dynamic portal type * feat(core,docs): added example of extended loading configuration of the dialog * fix(core): fixed object identifier test * fix(core): fixed vertical navigation tests * chore(core): pr feedback * feat(core,platform): slider horizon update (#10125) * feat(core,platform): slider horizon update * feat(core,platform): standalone slider component * chore: updated deps * chore: removed DestroyService usages and replaced it with built-in functionality * chore: updated deps * feat(platform): slider jest migration * feat(core): shellbar horizon update (#10275) * feat(core): shellbar horizon update * fix(core): fix unit tests * feat(core): horizon carousel update (#10274) * feat(core,platform): checkbox horizon update (#10315) * feat(core,platform): checkbox horizon update * fix(core): fix unit tests * fix(cdk): resolve conflicts after rebase * chore: adjust commitlint max symbols * fix(e2e): try to fix failing e2e test * feat(core): toolbar horizon update (#10314) * feat(core): toolbar horizon update * fix(core): fix unit tests * fix(core): pr comments * feat(platform): message popover horizon update (#10317) * feat(platform): message popover horizon update * fix(platform): correct button state * feat: fd-title standalone migration * feat: fd-popover standalone migration * fix: fixed deleted symbol usage * chore: nx format write * fix(e2e): skip false negative tests BREAKING CHANGE: Vertical carousel markup change: Previously navigation buttons had icons `sap-icon--slim-arrow-left` and `sap-icon--slim-arrow-left` ignoring the direction. Now if vertical navigation is applied, buttons will have icons `sap-icon--slim-arrow-up` and `sap-icon--slim-arrow-down` respectively. Toolbar markup change: Removed inner `<div class="fd-toolbar">...</div>`. Now classes and other attributes applied to the root `fd-toolbar` element. Radio button: Projected content now wrapped with `<span class="fd-radio__text">` --------- Co-authored-by: Giorgi Cheishvili <giorgi.cheishvili@outlook.com> Co-authored-by: Mike O'Donnell <mikerodonnell89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #9852