Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adds links to headers #1260

Merged
merged 6 commits into from
Sep 17, 2019
Merged

docs: adds links to headers #1260

merged 6 commits into from
Sep 17, 2019

Conversation

stefanoScalzo
Copy link
Contributor

Please provide a link to the associated issue.

fixes #1182

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Sep 12, 2019 •
edited
Loading

Deploy preview for fundamental-ngx ready!

Built with commit f875f9c

https://deploy-preview-1260--fundamental-ngx.netlify.com

JKMarkowski
JKMarkowski suggested changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stefanoScalzo
The scroll functionlity should be in docs-section-title.component, every instance of this component can read the fragment from url and check with assigned id. Also you should change naming of fragment to idFromUrl or something like that.

apps/docs/src/app/documentation/component-docs/action-bar/action-bar-docs.component.ts Outdated
});
}

ngAfterViewInit(): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend putting the scroll functionality in docs-section-title.component

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try also to avoid using for loop in the code, instead of it you can use .forEach, or find / filter.

@stefanoScalzo stefanoScalzo force-pushed the docs/#1182-add-link-before-header-title branch from d04e391 to 15e63d1 Compare September 13, 2019 20:05
@stefanoScalzo stefanoScalzo force-pushed the docs/#1182-add-link-before-header-title branch from 15e63d1 to ddd8aee Compare September 13, 2019 20:08
@stefanoScalzo stefanoScalzo changed the title docs: #1182: adds links to headers docs: adds links to headers Sep 13, 2019
JKMarkowski
JKMarkowski suggested changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leftovers are in 26 examples. Remove it and we can approve this PR :)

apps/docs/src/app/documentation/component-docs/action-bar/action-bar-docs.component.ts Outdated
private fragment: any;
@ViewChildren(DocsSectionTitleComponent, { read: ElementRef }) myList: QueryList<ElementRef>;

constructor(private route: ActivatedRoute) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stefanoScalzo, please remove these leftovers.

@stefanoScalzo stefanoScalzo force-pushed the docs/#1182-add-link-before-header-title branch from c0867b4 to 56a5a58 Compare September 16, 2019 17:37
@JKMarkowski JKMarkowski self-requested a review September 17, 2019 07:44
@droshev droshev added this to the sprint 20 - Ygritte milestone Sep 17, 2019
@droshev droshev added this to In progress in Development via automation Sep 17, 2019
@droshev droshev added the documentation There is an issue with documentation label Sep 17, 2019
@stefanoScalzo stefanoScalzo merged commit f597a44 into master Sep 17, 2019
Development automation moved this from In progress to Done Sep 17, 2019
@droshev droshev deleted the docs/#1182-add-link-before-header-title branch September 20, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKMarkowski JKMarkowski JKMarkowski approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@droshev droshev Awaiting requested review from droshev

Assignees
No one assigned
Labels
documentation There is an issue with documentation
Projects
None yet
Milestone
sprint 20 - Ygritte
Development

Successfully merging this pull request may close these issues.

feat: add link before header title
5 participants
@stefanoScalzo @CLAassistant @JKMarkowski @InnaAtanasova @droshev