-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adds links to headers #1260
Merged
stefanoScalzo
merged 6 commits into
master
from
docs/#1182-add-link-before-header-title
Sep 17, 2019
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
11f39f6
#1182: adds links to headers
stefanoScalzo ddd8aee
changed to docs-section-title and removed from other components
stefanoScalzo dcd5a27
removed the 29 edits
stefanoScalzo 56a5a58
resolve conflict
stefanoScalzo 3b9578f
removed excess code and resolved conflicts
stefanoScalzo f875f9c
fixed spacing in between h2 and separator
stefanoScalzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 30 additions & 30 deletions
60
apps/docs/src/app/documentation/component-docs/action-bar/action-bar-docs.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,62 +1,62 @@ | ||
<h2>Action bar with back button, description and action buttons</h2> | ||
<fd-docs-section-title [id]="'actionbar-standard'" [componentName]="'action-bar'"> | ||
Action bar with back button, description and action buttons | ||
</fd-docs-section-title> | ||
<description> | ||
Standard action bar which will likely fit most use cases. | ||
Standard action bar which will likely fit most use cases. | ||
</description> | ||
<component-example [name]="'ex1'"> | ||
<fd-action-bar-back-example></fd-action-bar-back-example> | ||
<fd-action-bar-back-example></fd-action-bar-back-example> | ||
</component-example> | ||
<code-example [exampleFiles]="backButtonExample"></code-example> | ||
|
||
<separator></separator> | ||
|
||
|
||
|
||
<h2>Action bar with long page title</h2> | ||
<fd-docs-section-title [id]="'actionBar-longPageTitle'" [componentName]="'action-bar'"> | ||
Action bar with long page title | ||
</fd-docs-section-title> | ||
<description> | ||
Display a page title. If the page title is a long string, it must truncate and display ellipsis after it crosses the | ||
width of the title bar. | ||
Display a page title. If the page title is a long string, it must truncate and display ellipsis after it crosses the | ||
width of the title bar. | ||
</description> | ||
<component-example [name]="'ex2'"> | ||
<fd-action-bar-long-string-title-truncation-example></fd-action-bar-long-string-title-truncation-example> | ||
<fd-action-bar-long-string-title-truncation-example></fd-action-bar-long-string-title-truncation-example> | ||
</component-example> | ||
<code-example [exampleFiles]="titleTruncationExample"></code-example> | ||
|
||
<separator></separator> | ||
|
||
|
||
|
||
|
||
<h2>Action bar with main actions and no Back button</h2> | ||
<fd-docs-section-title [id]="'actionBar-MA_noBack'" [componentName]="'action-bar'"> | ||
Action bar with main actions and no Back button | ||
</fd-docs-section-title> | ||
<description> | ||
Display main actions within the Action bar. This allows for users to find important page actions in a | ||
consistent area no matter what page they are on within the application. | ||
Display main actions within the Action bar. This allows for users to find important page actions in a consistent | ||
area no matter what page they are on within the application. | ||
</description> | ||
<component-example [name]="'ex3'"> | ||
<fd-action-bar-no-back-example></fd-action-bar-no-back-example> | ||
<fd-action-bar-no-back-example></fd-action-bar-no-back-example> | ||
</component-example> | ||
<code-example [exampleFiles]="noBackButtonExample"></code-example> | ||
|
||
<separator></separator> | ||
|
||
<h2>Several Main Actions in a Contextual Menu</h2> | ||
<fd-docs-section-title [id]="'actionBar-MA'" [componentName]="'action-bar'"> | ||
Several Main Actions in a Contextual Menu | ||
</fd-docs-section-title> | ||
<description> | ||
When there are several main actions for a page, consider displaying them under a contextual menu. | ||
This allows the user to look in the same position they are used to but avoids cluttering the action bar with more than | ||
3-4 actions. | ||
This also works well for a responsive/adaptive application. | ||
When there are several main actions for a page, consider displaying them under a contextual menu. This allows the | ||
user to look in the same position they are used to but avoids cluttering the action bar with more than 3-4 actions. | ||
This also works well for a responsive/adaptive application. | ||
</description> | ||
<component-example [name]="'ex4'"> | ||
<fd-action-bar-contextual-menu-example></fd-action-bar-contextual-menu-example> | ||
<fd-action-bar-contextual-menu-example></fd-action-bar-contextual-menu-example> | ||
</component-example> | ||
<code-example [exampleFiles]="actionsContextualMenuHtml"></code-example> | ||
|
||
<separator></separator> | ||
|
||
<h2>Action bar mobile view</h2> | ||
<fd-docs-section-title [id]="'actionBar-Mobile'" [componentName]="'action-bar'"> | ||
Action bar mobile view | ||
</fd-docs-section-title> | ||
<description> | ||
The action bar has an alternate way of displaying which is much more appropriate for mobile users. | ||
The action bar has an alternate way of displaying which is much more appropriate for mobile users. | ||
</description> | ||
<component-example [name]="'ex5'"> | ||
<fd-action-bar-mobile-example></fd-action-bar-mobile-example> | ||
<fd-action-bar-mobile-example></fd-action-bar-mobile-example> | ||
</component-example> | ||
<code-example [exampleFiles]="mobileViewHtml"></code-example> | ||
<code-example [exampleFiles]="mobileViewHtml"></code-example> |
73 changes: 46 additions & 27 deletions
73
apps/docs/src/app/documentation/component-docs/action-bar/action-bar-docs.component.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,41 +1,60 @@ | ||
import { Component } from '@angular/core'; | ||
import { Component, ViewChildren, ElementRef, QueryList, OnInit, AfterViewInit } from '@angular/core'; | ||
|
||
import * as backButtonExample from '!raw-loader!./examples/action-bar-back-example.component.html'; | ||
import * as titleTruncationExample from '!raw-loader!./examples/action-bar-long-string-title-truncation-example.component.html'; | ||
import * as contextualMenuExample from '!raw-loader!./examples/action-bar-contextual-menu-example.component.html'; | ||
import * as mobileExample from '!raw-loader!./examples/action-bar-mobile-example.component.html'; | ||
import * as noBackButtonExample from '!raw-loader!./examples/action-bar-no-back-example.component.html'; | ||
import { ExampleFile } from '../../core-helpers/code-example/example-file'; | ||
import { DocsSectionTitleComponent } from '../../core-helpers/docs-section-title/docs-section-title.component'; | ||
import { ActivatedRoute } from '@angular/router'; | ||
|
||
@Component({ | ||
selector: 'app-toolbar', | ||
templateUrl: './action-bar-docs.component.html', | ||
styleUrls: ['action-bar-docs.component.scss'] | ||
}) | ||
export class ActionBarDocsComponent { | ||
|
||
backButtonExample: ExampleFile[] = [{ | ||
language: 'html', | ||
code: backButtonExample | ||
}]; | ||
|
||
titleTruncationExample: ExampleFile[] = [{ | ||
language: 'html', | ||
code: titleTruncationExample | ||
}] | ||
|
||
noBackButtonExample: ExampleFile[] = [{ | ||
language: 'html', | ||
code: noBackButtonExample | ||
}]; | ||
|
||
actionsContextualMenuHtml: ExampleFile[] = [{ | ||
language: 'html', | ||
code: contextualMenuExample | ||
}]; | ||
|
||
mobileViewHtml: ExampleFile[] = [{ | ||
language: 'html', | ||
code: mobileExample | ||
}]; | ||
export class ActionBarDocsComponent implements OnInit { | ||
backButtonExample: ExampleFile[] = [ | ||
{ | ||
language: 'html', | ||
code: backButtonExample | ||
} | ||
]; | ||
|
||
titleTruncationExample: ExampleFile[] = [ | ||
{ | ||
language: 'html', | ||
code: titleTruncationExample | ||
} | ||
]; | ||
|
||
noBackButtonExample: ExampleFile[] = [ | ||
{ | ||
language: 'html', | ||
code: noBackButtonExample | ||
} | ||
]; | ||
|
||
actionsContextualMenuHtml: ExampleFile[] = [ | ||
{ | ||
language: 'html', | ||
code: contextualMenuExample | ||
} | ||
]; | ||
|
||
mobileViewHtml: ExampleFile[] = [ | ||
{ | ||
language: 'html', | ||
code: mobileExample | ||
} | ||
]; | ||
private fragment: any; | ||
@ViewChildren(DocsSectionTitleComponent, { read: ElementRef }) myList: QueryList<ElementRef>; | ||
|
||
constructor(private route: ActivatedRoute) {} | ||
|
||
ngOnInit() {} | ||
|
||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stefanoScalzo, please remove these leftovers.