Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate buttons 0.12.0 #3400

Merged
merged 12 commits into from
Sep 29, 2020
Merged

fix: migrate buttons 0.12.0 #3400

merged 12 commits into from
Sep 29, 2020

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Sep 25, 2020 •
edited by InnaAtanasova

Please provide a link to the associated issue.

part of #3370

Please provide a brief summary of this pull request.

There is new way to add text inside button component. The [label] property should be used now instead of adding text as a content. The content still works fine, unless it's used with icons.

BREAKING CHANGE:

The value for the text button is now passed as an input property, not as content projection.

Before: <button fd-button>Text</button>
After: <button fd-button [label]="'Text'"></button

Please check whether the PR fulfills the following requirements

Documentation checklist:

@netlify
Copy link

netlify bot commented Sep 25, 2020 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit 1266f4e

https://deploy-preview-3400--fundamental-ngx.netlify.app

@droshev droshev added this to the Sprint 46 - Montreal milestone Sep 25, 2020
@droshev droshev added the 0.22.0 label Sep 25, 2020
@droshev droshev added this to In progress in Development via automation Sep 25, 2020
@JKMarkowski JKMarkowski changed the title WIP fix: migrate buttons 0.12.0 fix: migrate buttons 0.12.0 Sep 28, 2020
@JKMarkowski JKMarkowski requested a review from a team September 28, 2020 09:21
@JKMarkowski
Copy link
Contributor Author

image

@JKMarkowski
Copy link
Contributor Author

JKMarkowski commented Sep 28, 2020 •
edited

  • Time increase/decrease button doesn't have icon
    image

  • Miss-aligned icons in Alert - Alert Deprecated
    image

  • Dialog button doesn't have icon
    image

  • Message strip - icons not centered
    image

  • Panel - Icon inside button is missing
    image

  • Split button - truncation
    image

  • Message Strip is missing close icons
    image

@mikerodonnell89
Copy link
Member

Dialogs do have buttons now but they are not centered

Screen Shot 2020-09-28 at 1 46 23 PM

@JKMarkowski
Copy link
Contributor Author

@mikerodonnell89 Dialog close button has been fixed

@JKMarkowski JKMarkowski mentioned this pull request Sep 29, 2020
Merged
5 tasks
This was referenced Sep 29, 2020
Merged
Merged
@JKMarkowski JKMarkowski requested a review from a team September 29, 2020 14:17
@InnaAtanasova InnaAtanasova merged commit 5ac24c2 into master Sep 29, 2020
Development automation moved this from In progress to Done Sep 29, 2020
@InnaAtanasova InnaAtanasova deleted the fix/migrate-buttons-0.12.0 branch September 29, 2020 16:24
@sKudum sKudum mentioned this pull request Oct 5, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@salarenko salarenko salarenko approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@JKMarkowski JKMarkowski

Labels
None yet
Projects
No open projects
Development
  
Done
Milestone
Sprint 47 - Bali
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JKMarkowski @mikerodonnell89 @salarenko @InnaAtanasova @droshev