fix(core): remove hammerjs from library #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: fbda745 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60f0461f10776d0007626f91 😎 Browse the preview: https://deploy-preview-5980--fundamental-ngx.netlify.app |
Comment on lines
+7
to
+19
| .fd-carousel__content { | ||
| > div { | ||
| touch-action: pan-x; | ||
| user-select: none; | ||
| -webkit-user-drag: none; | ||
| -webkit-tap-highlight-color: rgba(0, 0, 0, 0); | ||
|
|
||
| &.fd-carousel__content--horizontal { | ||
| touch-action: pan-y; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Please move this to fundamental-styles
There was a problem hiding this comment.
I've created separate bug in fundamental-styles to reflect the carousel component's layout from fundamental-ngx: SAP/fundamental-styles#2574
| /** @hidden */ | ||
| private _dragStarted = false; | ||
|
|
||
| /** An RxJS Subject that will kill the data stream upon component’s destruction (for unsubscribing) */ |
| this._hammer.on('panstart', () => this._handlePanStart()); | ||
| this._hammer.on('panend', (event) => this._handlePanEnd(event.deltaX)); | ||
| } | ||
| private _subscribeToEvents( |
InnaAtanasova
approved these changes
Jul 14, 2021
N1XUS
added
bug
kavya-b
reviewed
Jul 15, 2021
N1XUS
force-pushed
the
fix/4132-remove-hammerjs
branch
from
032b0d9
to
105878a
Compare
kavya-b
reviewed
Jul 15, 2021
Betrozov
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Closes #4132
Please provide a brief summary of this pull request.
Removed hammerjs library from fundamental-ngx/core and refactored carousel component
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md