fix: Add placement option to date/datetime picker #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 01be2ab |
mikerodonnell89
requested changes
Jun 14, 2019
| @@ -19,7 +19,8 @@ <h2>Range Date Picker</h2> | |||
|
|
|||
| <separator></separator> | |||
| <h2>Internationalization</h2> | |||
| <description>It is possible to internationalize both the aria labels and the month names/weekdays through providing a service.</description> | |||
| <description>It is possible to internationalize both the aria labels and the month names/weekdays through providing a service. | |||
| There is also added <code>[position]</code> attribute which allows us to decide where popup should be shown.</description> | |||
There was a problem hiding this comment.
this note probably does not belong in the "internationalisation" section
| @@ -52,7 +52,7 @@ export class CustomI18nLabels extends CalendarI18nLabels { | |||
|
|
|||
| @Component({ | |||
| selector: 'fd-datepicker-i18n-example', | |||
| template: `<fd-date-picker [(ngModel)]="selectedDay"></fd-date-picker>`, | |||
| template: `<fd-date-picker [(ngModel)]="selectedDay" [placement]="'top-end'"></fd-date-picker>`, | |||
There was a problem hiding this comment.
Again this probably does not belong in the i18n section but may warrant its own example
|
@JKMarkowski would you mind fixing the merge conflicts |
|
@mikerodonnell89 Sure, it's done. |
mikerodonnell89
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes #775
Please provide a brief summary of this pull request.
I added placement input to date and datetime picker.
If this is a new feature, have you updated the documentation?
I added examples on date and datetime docs.