fix: add polyfills for ie11 issues #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbadan
commented
Jun 19, 2020
| ]; | ||
|
|
||
| const productionPlugins = [ | ||
| 'babel-plugin-transform-react-constant-elements', | ||
| '@babel/plugin-transform-react-constant-elements', |
There was a problem hiding this comment.
This was using the babel 6 plugin - upgraded to 7.
jbadan
commented
Jun 19, 2020
| @@ -9,13 +9,11 @@ const defaultPresets = [ | |||
|
|
|||
| const defaultPlugins = [ | |||
| ['@babel/plugin-proposal-class-properties', { loose: true }], | |||
| ['@babel/plugin-proposal-object-rest-spread', { loose: true }], | |||
| '@babel/plugin-transform-runtime', | |||
| '@babel/plugin-transform-object-assign' | |||
There was a problem hiding this comment.
No longer needs object assign or object rest spread due to core-js
|
Deploy preview for fundamental-react ready! Built with commit 6b22cae |
jbadan
commented
Jun 19, 2020
| @@ -120,8 +119,7 @@ | |||
| "react-dom": "^16.8.0", | |||
| "react-router-dom": "^5.2.0", | |||
| "react-syntax-highlighter": "^12.2.1", | |||
| "react-test-renderer": "^16.13.1", | |||
| "regenerator-runtime": "^0.13.5", | |||
There was a problem hiding this comment.
react-test-renderer should be in sync with react version. regenerator runtime was leftover from old docs site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calendar/DatePicker/InputGroup were not working in ie11 due to string.includes/array.includes.
Added polyfilling (no global pollution) to build pipeline to avoid this issue in the future.
fixes #issueid