-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add polyfills for ie11 issues #1099
Conversation
]; | ||
|
||
const productionPlugins = [ | ||
'babel-plugin-transform-react-constant-elements', | ||
'@babel/plugin-transform-react-constant-elements', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was using the babel 6 plugin - upgraded to 7.
@@ -9,13 +9,11 @@ const defaultPresets = [ | |||
|
|||
const defaultPlugins = [ | |||
['@babel/plugin-proposal-class-properties', { loose: true }], | |||
['@babel/plugin-proposal-object-rest-spread', { loose: true }], | |||
'@babel/plugin-transform-runtime', | |||
'@babel/plugin-transform-object-assign' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needs object assign or object rest spread due to core-js
Deploy preview for fundamental-react ready! Built with commit 6b22cae |
@@ -120,8 +119,7 @@ | |||
"react-dom": "^16.8.0", | |||
"react-router-dom": "^5.2.0", | |||
"react-syntax-highlighter": "^12.2.1", | |||
"react-test-renderer": "^16.13.1", | |||
"regenerator-runtime": "^0.13.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-test-renderer should be in sync with react version. regenerator runtime was leftover from old docs site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 🚢
Description
Calendar/DatePicker/InputGroup were not working in ie11 due to string.includes/array.includes.
Added polyfilling (no global pollution) to build pipeline to avoid this issue in the future.
fixes #issueid