Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1130 Adding disabled and readonly props to search input #1140

Merged
merged 8 commits into from
Aug 6, 2020
Merged

fix: #1130 Adding disabled and readonly props to search input #1140

merged 8 commits into from
Aug 6, 2020

Conversation

athulvraj
Copy link
Contributor

Description

SearchInput doesn't have readyOnly and disabled props

fixes #1130

@athulvraj athulvraj requested a review from jbadan July 30, 2020 16:05
@netlify
Copy link

netlify bot commented Jul 30, 2020 •
edited
Loading

Deploy preview for fundamental-react ready!

Built with commit 8cc4034

https://deploy-preview-1140--fundamental-react.netlify.app

jbadan
jbadan approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 💯

prsdthkr
prsdthkr reviewed Aug 1, 2020
View reviewed changes
Copy link
Member

@prsdthkr prsdthkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you fix the accessibility issues in the stories and add the new props to the dev story knobs while you're at it?

prsdthkr
prsdthkr approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@prsdthkr prsdthkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛴

@athulvraj athulvraj merged commit 8934e9c into master Aug 6, 2020
@prsdthkr prsdthkr deleted the Adding-disabled-and-readonly-props-to-searchInput branch September 15, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

@prsdthkr prsdthkr prsdthkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SearchInput doesn't expose readyOnly and disabled
4 participants
@athulvraj @jbadan @prsdthkr @athulvijayaraj