Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchInput doesn't expose readyOnly and disabled #1130

Closed
I065450 opened this issue Jul 19, 2020 · 0 comments · Fixed by #1140
Closed

SearchInput doesn't expose readyOnly and disabled #1130

I065450 opened this issue Jul 19, 2020 · 0 comments · Fixed by #1140
Assignees
@athulvraj

Comments

@I065450
Copy link
Contributor

I065450 commented Jul 19, 2020 •
edited
Loading

Description

SearchInput doesn't expose readyOnly and disabled,
If I give this props to the input (inputProps), it is working but there is no style for it- see in the image:

image

(first one is SearchInput second is text input)

Versions

0.11.0-rc.29
@athulvraj athulvraj self-assigned this Jul 21, 2020
@athulvraj athulvraj mentioned this issue Jul 30, 2020
Merged
athulvraj added a commit that referenced this issue Aug 6, 2020
@athulvraj @prsdthkr
fix: #1130 Adding disabled and readonly props to search input (#1140)
8934e9c 
* Adding disabled and readonly props to search input

* Adding new props to the dev story knobs

* Updating storyshot

* Fixing accessibility issue in search button

* fixing test issues

* fix a11y violations

* update snapshots

Co-authored-by: Prasad Thakur <prasad.thakur@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athulvraj athulvraj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #1130 Adding disabled and readonly props to search input SAP/fundamental-react
2 participants
@athulvraj @I065450