feat: make shellbar popovers customizable #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit e7098bb |
skvale
reviewed
Sep 25, 2020
| productMenu: PropTypes.object, | ||
| productSwitch: PropTypes.object, | ||
| profileMenu: PropTypes.object | ||
| }, |
There was a problem hiding this comment.
How about separating each of them out?
Shellbar.PropTypes = {
actionMenuPopoverProps: PropTypes.object,
mobileMenuPopoverProps: PropTypes.object,
notificationsPopoverProps: PropTypes.object,
productMenuPopoverProps: PropTypes.object,
productSwitchPopoverProps: PropTypes.object,
profileMenuPopoverProps: PropTypes.object
},There was a problem hiding this comment.
Yeah, I started out with that but thought there are too many popovers. So I think packaging them would be cleaner, no?
There was a problem hiding this comment.
Do you think we would need to make other changes to the popovers or just placement overrides?
There was a problem hiding this comment.
Consumers might need to customize some cosmetic props like noArrow, widthSizingType or add popperClassName and other stuff. It would be a little more future proof.
jbadan
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this change, we update the Shellbar component to accept props to be spread to the Popovers of the action menu, collapsed mobile menu, notifications menu, product menu, product switch popover, and the profile menu. This will allow consumers to customize these; for example, set the
placement.fixes #919