-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make shellbar popovers customizable #1222
Conversation
Deploy preview for fundamental-react ready! Built with commit e7098bb |
productMenu: PropTypes.object, | ||
productSwitch: PropTypes.object, | ||
profileMenu: PropTypes.object | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about separating each of them out?
Shellbar.PropTypes = {
actionMenuPopoverProps: PropTypes.object,
mobileMenuPopoverProps: PropTypes.object,
notificationsPopoverProps: PropTypes.object,
productMenuPopoverProps: PropTypes.object,
productSwitchPopoverProps: PropTypes.object,
profileMenuPopoverProps: PropTypes.object
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I started out with that but thought there are too many popovers. So I think packaging them would be cleaner, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we would need to make other changes to the popovers or just placement overrides?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consumers might need to customize some cosmetic props like noArrow
, widthSizingType
or add popperClassName
and other stuff. It would be a little more future proof.
Description
In this change, we update the Shellbar component to accept props to be spread to the Popovers of the action menu, collapsed mobile menu, notifications menu, product menu, product switch popover, and the profile menu. This will allow consumers to customize these; for example, set the
placement
.fixes #919