chore: Prop spreading unit tests #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-a-smith
requested review from
CodesOfRa,
jeffredodd,
droshev,
bcullman,
mobot11,
cjskillingstad,
jbadan,
chrismanciero and
InnaAtanasova
|
Looks good 🚢 (once we get the publishing working ;) ) |
jbadan
approved these changes
Jan 14, 2019
|
@greg-a-smith So, to be clear the added |
|
@bcullman That's correct, for the most part. There are a couple places where it might get fairly complicated so I just left a generic comment that more tests will need to be added as functionality is added. |
greg-a-smith
added a commit
that referenced
this pull request
Mar 5, 2019
* Added configuration for enzyme adapter * Added prop spreading tests for ActionBar * Added prop spreading tests for Alert and Badge * Added prop spreading tests for Breadcrumb and Button * Added prop spreading tests for Calendar and ComboboxInput * Added TODO markers on the comments for skipped tests * Added prop spreading tests for DatePicker and Dropdown * Added prop spreading tests for Forms and Icon * Added prop spreading tests for Identifier and Image * Added prop spreading tests for InlineHelp and InputGroup * Added prop spreading tests for ListGroup and LocalizationEditor * Added prop spreading tests for MegaMenu and Menu * Added prop spreading tests for Modal and MultiInput * Added prop spreading tests for Pagination and Panel * Added prop spreading tests for Popover and SearchInput * Added prop spreading tests for Shellbar and SideNavigation * Added prop spreading tests for SideNavigation and Table * Added prop spreading tests for Tabs and Tile * Added prop spreading tests for Time and TimePicker * Added prop spreading tests for Toggle and Token * Added prop spreading tests for Tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a number of unit tests to verify that props can be spread through each component and end up in the emitted HTML. The tests use
data-sampleas the HTML attribute (prop). There are a number of components and elements that do not allow these props to be spread and I tried to put a skipped test with a description of the test needed so it helps the developer(s) adding the additional prop spreading functionality.NOTE: Most of the
.testfiles were also changed from 2 space indents to 4 so my apologies for the massive diffs in these files. I didn't change any existing tests. The only thing I did was add adescribeblock called "Prop spreading" that contains the prop spreading tests.Fixes #167.