Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remaining prop spreading issues #214

Closed
jbadan opened this issue Jan 16, 2019 · 1 comment
Closed

fix remaining prop spreading issues #214

jbadan opened this issue Jan 16, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@jbadan
Copy link
Contributor

jbadan commented Jan 16, 2019

#184 created disabled unit tests for prop spreading to sub-components. Fix components so that props can be spread to all elements and enable/write tests.

If you work on one of the components, please update wiki tracking page here: https://github.com/SAP/fundamental-react/wiki/Prop-Spreading

@jbadan jbadan added the help wanted Extra attention is needed label Jan 16, 2019
@jbadan
Copy link
Contributor Author

jbadan commented Jan 22, 2019

fixed by #264, #261, #260, #258, #257, #256, #255, #254, #253, #251, #250, #248, #246, #243, #242, #241, #240, #237, #236, #235, #233, #231, #230, #227, #226, #224, #223, #222, #221, #219

@jbadan jbadan closed this as completed Jan 22, 2019
@jbadan jbadan moved this from In progress to Done in Pre-production fundamental-react improvements Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
No open projects
Development

No branches or pull requests

1 participant