Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add fundamental bot to release script #194

Merged
merged 3 commits into from
Jan 15, 2019
Merged

fix: add fundamental bot to release script #194

merged 3 commits into from
Jan 15, 2019

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented Jan 14, 2019

Adds fundamental-bot to release script as it has admin rights to push to master.

Fixes regex where there was possible failures due to use of /s for whitespace.

@jbadan jbadan requested a review from bcullman January 14, 2019 23:58
bcullman
bcullman approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@bcullman bcullman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works!!!

🚢

@jbadan jbadan merged commit 96e3080 into master Jan 15, 2019
@jbadan jbadan deleted the fix/release-script-2 branch January 15, 2019 02:44
greg-a-smith pushed a commit that referenced this pull request Mar 5, 2019
@jbadan
fix: add fundamental bot to release script (#194)
221dd71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcullman bcullman bcullman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbadan @bcullman