Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eslint no console #196

Merged
merged 3 commits into from
Jan 15, 2019
Merged

fix: eslint no console #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e29066e
Enabled no-console eslint rule and fixed lint errors
greg-a-smith Jan 14, 2019
88e74b0
Merge changes from master
greg-a-smith Jan 15, 2019
d361ed0
Merge branch 'master' into fix/eslint-no-console
greg-a-smith Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ rules:
loosely-restrict-imports/loosely-restrict-imports: [2, '.jsx']
new-cap: 2
no-cond-assign: 2
#no-console: 2
no-console: 2
no-constant-condition: 2
no-control-regex: 2
no-debugger: 2
Expand Down
2 changes: 1 addition & 1 deletion src/MultiInput/MultiInput.Component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class MultiInputComponent extends Component {
}

performTagsUpdate = aTags => {
console.log(aTags);
// console.log(aTags);
};

multiInputCode = `<MultiInput
Expand Down
2 changes: 1 addition & 1 deletion src/Pagination/Pagination.Component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { DocsTile, DocsText, Separator, Header, Description, Import, Properties,

export const PaginationComponent = () => {
const handleClick = event => {
console.log(`Page clicked - ${event}`);
// console.log(`Page clicked - ${event}`);
};
return (
<div>
Expand Down
2 changes: 2 additions & 0 deletions src/registerServiceWorker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
// To learn more about the benefits of this model, read https://goo.gl/KwvDNy.
// This link also includes instructions on opting out of this behavior.

/* eslint-disable no-console */

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have a matching eslint-enable no-console at the bottom?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but not sure. When we did work in NUI Widgets and disabled a rule for a given file, we never added any eslint-enable statements at the bottom.

const isLocalhost = Boolean(
window.location.hostname === 'localhost' ||
// [::1] is the IPv6 localhost address.
Expand Down