fix: eslint no console #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-a-smith
requested review from
jeffredodd,
droshev,
bcullman,
mobot11,
cjskillingstad,
jbadan,
chrismanciero and
InnaAtanasova
bcullman
reviewed
Jan 15, 2019
| @@ -8,6 +8,8 @@ | |||
| // To learn more about the benefits of this model, read https://goo.gl/KwvDNy. | |||
| // This link also includes instructions on opting out of this behavior. | |||
|
|
|||
| /* eslint-disable no-console */ | |||
|
|
|||
There was a problem hiding this comment.
should this have a matching eslint-enable no-console at the bottom?
There was a problem hiding this comment.
I don't think so, but not sure. When we did work in NUI Widgets and disabled a rule for a given file, we never added any eslint-enable statements at the bottom.
greg-a-smith
requested review from
CodesOfRa and
a team
and removed request for
CodesOfRa,
jeffredodd,
droshev,
mobot11,
cjskillingstad,
jbadan,
chrismanciero and
InnaAtanasova
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the
no-consoleeslint rule and fixed lint errors.#169