fix: eslint no empty #197
Merged
fix: eslint no empty #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-a-smith
requested review from
CodesOfRa,
jeffredodd,
droshev,
bcullman,
mobot11,
cjskillingstad,
jbadan,
chrismanciero and
InnaAtanasova
bcullman
reviewed
Jan 15, 2019
src/Time/Time.js
Outdated
| @@ -316,6 +315,7 @@ export class Time extends Component { | |||
| super(props); | |||
| const { time } = this.props; | |||
| if (time.hour !== '00') { | |||
| // do nothing | |||
There was a problem hiding this comment.
This can just be flipped to if (time.hour === '00')
There was a problem hiding this comment.
You know ... I hmmm'd and hah'd over this. I ended up doing this because of my fear of the undefined, null, etc. values. But, I may have just been worrying over nothing. I guess undefined and null would "not equal" 00 so maybe this will be just a quick change.
greg-a-smith
requested review from
a team
and removed request for
CodesOfRa,
jeffredodd,
droshev,
mobot11,
cjskillingstad,
jbadan,
chrismanciero and
InnaAtanasova
cjskillingstad
approved these changes
Jan 15, 2019
greg-a-smith
added a commit
that referenced
this pull request
Mar 5, 2019
* Enabled no-empty eslint rule and fixed lint errors * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the
no-emptyeslint rule and fixed lint errors.#169