Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remaining non-a11y eslint issues #169

Closed
bcullman opened this issue Jan 9, 2019 · 3 comments
Closed

fix remaining non-a11y eslint issues #169

bcullman opened this issue Jan 9, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@bcullman
Copy link
Contributor

bcullman commented Jan 9, 2019

see commented out rules in https://github.com/SAP/fundamental-react/blob/master/.eslintrc

they are:

#brace-style: 2
#compat/compat: 2
#eqeqeq: 2
#indent: [2, 4, {"SwitchCase": 1}]
#no-console: 2
#no-empty: 2
#no-nested-ternary: 2
#no-shadow: 2
#no-sparse-arrays: 2
#no-undefined: 2
#no-unused-vars: [2, { ignoreRestSiblings: true }]
#radix: 2
#react/jsx-sort-props: 2
#react/no-multi-comp: 2
#react/prop-types: 2
#react/react-in-jsx-scope: 2
#sort-imports: [2, { 'ignoreCase': true, 'ignoreMemberSort': false, 'memberSyntaxSortOrder': ['none', 'single', 'multiple', 'all'] }]
#use-isnan: 2
#valid-jsdoc: [2, { prefer: { 'return': 'returns'}}]
#valid-typeof: 2
@bcullman
Copy link
Contributor Author

bcullman commented Jan 10, 2019

for tracking purposes, it would be best to handle fixing each lint rule as its own PR - ie, a single PR should NOT be used to fix all of these simultaneously.

@bcullman bcullman added the help wanted Extra attention is needed label Jan 10, 2019
@jbadan jbadan assigned jbadan and unassigned jbadan Jan 11, 2019
@greg-a-smith
Copy link
Contributor

I have created a Wiki page to track our progress on each rule so people are not working on the same items. Please update the Wiki page when you work on a rule.

https://github.com/SAP/fundamental-react/wiki/ESLint-Rules

This was referenced Jan 17, 2019
@greg-a-smith greg-a-smith changed the title fix remaining eslint issues fix remaining eslint issues (non-a11y) Jan 17, 2019
@greg-a-smith greg-a-smith changed the title fix remaining eslint issues (non-a11y) fix remaining (non-a11y) eslint issues Jan 17, 2019
@greg-a-smith greg-a-smith changed the title fix remaining (non-a11y) eslint issues fix remaining non-a11y eslint issues Jan 17, 2019
@greg-a-smith
Copy link
Contributor

The only rule that wasn't fixed was react/no-multi-comp and that's up for debate amongst the team as to the best route forward. If it were to be implemented, it would be a large-scale refactoring effort and a separate story.

@jbadan jbadan moved this from In progress to Done in Pre-production fundamental-react improvements Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
No open projects
Development

No branches or pull requests

3 participants