fix: eslint valid jsdoc #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure about this one… we should discuss the merits of JS docs, if there are any. |
|
Discussing the merits is fine with me. I just chose to remove these since these are minimally useful at best and these are the only two files in the repo using JS docs. |
|
looks like most of the JSDocs lines came from @CodesOfRa, it woul dbe best if she chimes in before removing this. it does appear that we are manually documenting props in the *.Components.js files. If we were to use these JSDocs capabilities, instead, we should do it universally, and in a way that can be consumed automatically by ghpages. |
|
@bcullman @greg-a-smith we can remove them 👍 |
bcullman
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the
valid-jsdoceslint rule and fixed lint errors.#169