fix: eslint no unused vars #205
Conversation
| @@ -55,23 +55,23 @@ describe('<MultiInput />', () => { | |||
| }); | |||
|
|
|||
| // create a default multi-input control | |||
| test('create multi-input', () => { | |||
| xtest('create multi-input', () => { | |||
There was a problem hiding this comment.
@greg-a-smith: why are these test being x-ed?
There was a problem hiding this comment.
There was a to-do comment stating why snapshots were failing and the assertion was commented out causing the no-unused-vars lint error. To resolve all of the lint errors, the entire test ended up being commented out so I decided to uncomment everything and just x the tests until the to-do comments are resolved.
| productSwitcher={productSwitcher} | ||
| productSwitcherList={productSwitcherList} /> | ||
| ); | ||
|
|
There was a problem hiding this comment.
Were these made with the intention of using them in the snapshot tests?
There was a problem hiding this comment.
That's a good question. There were a bunch of variables defined to create it, but then it was never used. I will check the blame on this to see if someone wants to retain all this code in a separate branch, but it should all be removed from master.
There was a problem hiding this comment.
My bad, i think i forgot to make the snapshot call. I will create a chore: PR to add the call in there. This snapshot call bumps up the code coverage from 30% to about 85%
There was a problem hiding this comment.
@chrismanciero Do you want to fix it in this PR or create a separate one?
* Enabled no-unused-vars lint rule and fixed lint errors * solve coPilotShell no used var issue * update files for eslint failure
Enabled the
no-unused-varseslint rule and fixed lint errors.#169